[#45] Retrieve digid/eherkenning metadata automatically #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 96.20% 96.40% +0.19%
==========================================
Files 66 70 +4
Lines 3032 3196 +164
==========================================
+ Hits 2917 3081 +164
Misses 115 115
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vaszig
force-pushed
the
issue/45-retrieve-urls-from-metadata-file
branch
2 times, most recently
from
8e7414a to
3bfda54
Compare
Refactored base configuration model in order to provide a url and do all the fetching and parsing based on this. The urls are cached for a day and the xml file is updated via a command.
vaszig
force-pushed
the
issue/45-retrieve-urls-from-metadata-file
branch
from
3bfda54 to
4a09291
Compare
sergei-maertens
requested changes
Oct 17, 2023
digid_eherkenning/management/commands/update_stored_metadata.py
Outdated
Show resolved
Hide resolved
digid_eherkenning/management/commands/update_stored_metadata.py
Outdated
Show resolved
Hide resolved
digid_eherkenning/templates/admin/widgets/clearable_private_file_input.html
Outdated
Show resolved
Hide resolved
sergei-maertens
requested changes
Oct 20, 2023
sergei-maertens
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45
Closes open-formulieren/open-forms#3477