Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#58] Do not swap entityID with URL for eH #62

Merged
merged 2 commits into from
Mar 5, 2024
Merged

[#58] Do not swap entityID with URL for eH #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
410e44d
:bug: [#58] Do not swap entityID with URL for eH
SilviaAmAm Mar 1, 2024
e79459f
:white_check_mark: [#58] Update tests
SilviaAmAm Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions digid_eherkenning/models/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,11 +221,7 @@ def process_metadata_from_xml_source(self) -> tuple[dict[str, str], bytes]:
# sometimes the xml file contains urn instead of a url as an entity ID
# use the provided url instead
urls = {
"entityId": (
entity_id
if not (entity_id := idp.get("entityId")).startswith("urn:")
else self.metadata_file_source
),
"entityId": idp.get("entityId"),
"sso_url": idp.get("singleSignOnService", {}).get("url"),
"slo_url": idp.get("singleLogoutService", {}).get("url"),
}
Expand Down
2 changes: 1 addition & 1 deletion tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def test_fields_are_populated_on_eherkennig_save(self, get_matadata):
)
self.assertEqual(
config.idp_service_entity_id,
"https://eh01.staging.iwelcome.nl/broker/sso/1.13",
"urn:etoegang:HM:00000003520354760000:entities:9632",
)

@patch(
Expand Down
Loading