Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS module landing page #23898

Merged
merged 36 commits into from
Feb 1, 2023
Merged

CSS module landing page #23898

merged 36 commits into from
Feb 1, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Jan 26, 2023

Part of Q1-2023 project openwebdocs/project#147

Note, w3c/browser-specs#851 should fix the spec name appearing the same for 2 different specs on the blending and compositing page.

@estelle estelle requested a review from a team as a code owner January 26, 2023 02:03
@estelle estelle requested review from dipikabh and removed request for a team January 26, 2023 02:03
@estelle estelle marked this pull request as draft January 26, 2023 02:03
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jan 26, 2023
@estelle estelle requested review from Rumyra and Elchi3 January 26, 2023 02:04
@estelle estelle marked this pull request as ready for review January 26, 2023 02:04
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2023

Preview URLs

Flaws (1)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_Animations
Title: CSS animations
Flaw count: 1

  • macros:
    • /en-US/docs/Glossary/B%C3%A9zier_curve redirects to /en-US/docs/Glossary/Bezier_curve
External URLs (3)

URL: /en-US/docs/Web/CSS/Compositing_and_Blending
Title: CSS compositing and blending

(comment last updated: 2023-02-01 16:28:18)

@estelle estelle marked this pull request as draft January 26, 2023 02:08
@estelle estelle changed the title DRAFT: Feedback wanted: CSS module landing page Feedback wanted: CSS module landing page Jan 26, 2023
@estelle estelle added help wanted If you know something about this topic, we would love your help! and removed Content:CSS Cascading Style Sheets docs labels Jan 26, 2023
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this looks great.

I created a test module landing page so we could discuss the CSS module landing page format for the Q1 project openwebdocs/project#147

What do you all think of the format of this CSS module landing page?

Do the headings make sense for the CSS module landing template?

Idea:

  • 3 to 5 paragraphs about the module

  • Example (should this be in line, or have its own h2 level heading?)

  • Things to note, if any, about the module, displayed in the example. This being inline, not its own heading.

  • Reference

    • Properties
    • Data Types

We don't usually capitalize "Types" here: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Types .

  • Functions, or other important to module reference, if any (not present in this example)
  • Guides (not in this page, but if they were, is this the right spot?)

I think if we have guides they should be under their own H2. Guides aren't reference.

  • Associated content (not present in all modules, but likely in most)

    • associated properties
    • associated datatypes from other modules
    • associated concepts (things you need to know to get this module to work, such as time or hardware acceleration in animations)
  • Specifications (note, Make compositing-2 current, fix series.releaseUrl logic w3c/browser-specs#851 should fix the spec name appearing the same for 2 different specs)

  • See also - this would generally be for internal learn and guides, but we don't have anything on blending, so these are external.

Why wouldn't would "internal learn and guides" be in Guides?


This module provides for 16 different blending modes.

### Example
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be H2? And why not show source for the example? And might we want to have more than one, and then call it Examples?

I would have the example after the Reference and Associated content, as we usually do for docs (interactive examples aside).

Copy link
Member Author

@estelle estelle Jan 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually didn't want to have a header at all, but didn't know how to show EmbedLiveSample without a header ID. I want to keep the code hidden as this is supposed to be a very brief overview of "why" you would want to dig into the module, not an explanation of what the properties are or how they work. The example is part of the description, not an explanation, which is why it is with the description of the module.

The example also uses a lot of properties and values that are irrelevant to the module, such as borders, grid, backgrounds, gradients. Hiding the code enables including a complex example that shows the power of the whole module without worrying that the reader will get stuck on the details.

@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jan 27, 2023
@estelle
Copy link
Member Author

estelle commented Jan 27, 2023

Why wouldn't would "internal learn and guides" be in Guides?

I meant related articles that aren't mainly about the module, such as improving performance for scrolling, animation, and transitions. Yes, it discusses some features in the module, but it's not about the module.

@estelle estelle removed the Content:CSS Cascading Style Sheets docs label Jan 27, 2023
@dipikabh
Copy link
Contributor

Hi @estelle, I am a bit uncomfortable with duplicating content across pages. Because it increases our burden of keeping the same content up-to-date in all the pages that it appears.

There are two places where a concept/topic/module has a place in the sidebar - "Reference > Modules" and "Guides".

  1. How about we keep the page under "Reference > Modules" as purely a landing page, with links to all the related pages, and move all overarching explanations and examples to the Guides pages?
  2. How about we come up with a template for the landing page before touching all the module pages? We will eventually need one to ensure consistency across such pages.
  • 3 to 5 paragraphs about the module
  • Example (should this be in line, or have its own h2 level heading?)
  • Things to note, if any, about the module, displayed in the example. This being inline, not its own heading.

All this to me seems to be duplicating content and examples that one might find in the specific property page or in the respective guide. To look at it in another way, is this content/example that will not be covered in a guide or a property page?

  • Associated content (not present in all modules, but likely in most)
    • associated properties
    • associated datatypes from other modules
    • associated concepts (things you need to know to get this module to work, such as time or hardware acceleration in animations)
    • glossary terms (is this the right spot?)

How about this instead (dropped the repetitive 'associated'. I've used 'related' because it sounds easier and lighter to read and say):

  • Other related content
    • Properties
    • Data types
    • ...

Can "Glossary" terms be combined with "See also"?

Looking at a few existing pages:

@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jan 27, 2023
@estelle estelle marked this pull request as ready for review January 31, 2023 00:24
@estelle estelle removed the help wanted If you know something about this topic, we would love your help! label Jan 31, 2023
@estelle estelle changed the title Feedback wanted: CSS module landing page CSS module landing page Jan 31, 2023
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @estelle, the structure of the page looks good as well as the scoping of information. I've added some edits and questions.

files/en-us/web/css/css_animations/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_animations/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_animations/index.md Show resolved Hide resolved
files/en-us/web/css/css_animations/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_animations/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/compositing_and_blending/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/compositing_and_blending/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/compositing_and_blending/index.md Outdated Show resolved Hide resolved
- {{cssxref("background-image")}} CSS property
- {{glossary("stacking context")}} glossary term
- {{ SVGElement("feBlend")}} SVG filter primitive
- {{ SVGElement("feComposite")}} SVG filter primitive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should/can there be an order to list these? alphabetical within a category

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set them in order of relevance. Filter, which does something similar, seemed more relevant than background properties, which I then did put in alphabetical order.

files/en-us/web/css/compositing_and_blending/index.md Outdated Show resolved Hide resolved
@estelle estelle requested a review from dipikabh January 31, 2023 22:49
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @estelle. Thank you for the updates!

@dipikabh
Copy link
Contributor

dipikabh commented Feb 1, 2023

Lol, that comment was supposed to be 'blank line' not 'black line'

@dipikabh dipikabh merged commit dfa2737 into mdn:main Feb 1, 2023
@estelle estelle deleted the testlanding branch May 24, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants