-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS module landing page #23898
Merged
CSS module landing page #23898
Changes from 2 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
f55fccb
Test: let me know what you think
estelle 689d0cb
glossary
estelle ce1365e
animation
estelle 6281187
animation
estelle 233c738
animation
estelle 6a51071
tweaks
estelle 199bb14
tweaks
estelle 57cb928
animation example
estelle d60ef1a
prefers reduced motion
estelle cd36a8a
ground cover
estelle dab1526
details
estelle 2e84504
details
estelle 5beee71
change associated to related
estelle 4ebd970
tweaks
estelle 98913a5
make example keyboard stoppable
estelle d95f4bb
tweaks
estelle d3dfdd1
tests for discussions
estelle efeb0dc
tests for discussions
estelle 9bb88de
tests for discussions
estelle 38dd438
tests for discussions
estelle 57420b3
updated to Animation example to explain the code
estelle 8c0a670
updated to Animation example to explain the code
estelle 51e9591
make C&B match the template
estelle 7070256
updated to C&B example to explain the code
estelle a065682
updated to C&B: define filter in see also section
estelle 89f98f9
link to blob
estelle 9670b09
Apply suggestions from code review
estelle 9376a0a
Update index.md
estelle f7440d9
add experimental
estelle 54ed767
Update files/en-us/web/css/compositing_and_blending/index.md
estelle e23117b
missing property, experimental inline on other
estelle 40c98ae
testing spaces
estelle 57f6b89
spacing
estelle ece7d6d
spacing
estelle e2561e3
remove extra character
dipikabh b37f4c1
add black line before heading
dipikabh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be H2? And why not show source for the example? And might we want to have more than one, and then call it Examples?
I would have the example after the Reference and Associated content, as we usually do for docs (interactive examples aside).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually didn't want to have a header at all, but didn't know how to show EmbedLiveSample without a header ID. I want to keep the code hidden as this is supposed to be a very brief overview of "why" you would want to dig into the module, not an explanation of what the properties are or how they work. The example is part of the description, not an explanation, which is why it is with the description of the module.
The example also uses a lot of properties and values that are irrelevant to the module, such as borders, grid, backgrounds, gradients. Hiding the code enables including a complex example that shows the power of the whole module without worrying that the reader will get stuck on the details.