-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(http): Improvements to HTTP messages page #36029
Conversation
Preview URLs
Flaws (5)Note! 4 documents with no flaws that don't need to be listed. 🎉 URL:
External URLs (2)URL:
(comment last updated: 2024-11-22 01:08:10) |
This pull request has merge conflicts that must be resolved before it can be merged. |
This pull request has merge conflicts that must be resolved before it can be merged. |
Co-authored-by: Hamish Willee <[email protected]>
Thanks, Hamish. A couple of comments to have a look at, I think this is in a good state in general, what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is in a good state in general, what do you think?
Yes :-). You've addressed all my concerns and this is clearly much better. Note that I didn't re-review everything here - just the stuff that was changed or referred to in resolved notes.
... and I did a few minor typo-style fixes/merged in a suggestion for wording of yours.
Great, thanks a lot, Hamish 👍🏻 |
Description
Rewriting some of the content, adding some details about working with HTTP/2 messages, some diagrams.
Motivation
Keeping the content up-to-date
Drafting for now, more details to follow.