Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(http): Improvements to HTTP messages page #36029

Merged
merged 17 commits into from
Nov 22, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Sep 24, 2024

Description

Rewriting some of the content, adding some details about working with HTTP/2 messages, some diagrams.

Motivation

Keeping the content up-to-date

Drafting for now, more details to follow.

@github-actions github-actions bot added Content:WebAPI Web API docs Content:HTTP HTTP docs size/m [PR only] 51-500 LoC changed labels Sep 24, 2024
Copy link
Contributor

github-actions bot commented Sep 24, 2024

Preview URLs

Flaws (5)

Note! 4 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTTP/Messages
Title: HTTP messages
Flaw count: 5

  • images:
    • External image URL
    • External image URL
    • External image URL
    • External image URL
    • External image URL
External URLs (2)

URL: /en-US/docs/Web/HTTP/Messages
Title: HTTP messages

(comment last updated: 2024-11-22 01:08:10)

@bsmth bsmth changed the title chore(http) Improvements to HTTP messages page chore(http): Improvements to HTTP messages page Sep 24, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Oct 2, 2024
@bsmth bsmth marked this pull request as ready for review October 2, 2024 08:30
@bsmth bsmth requested review from a team as code owners October 2, 2024 08:30
@bsmth bsmth requested review from sideshowbarker and hamishwillee and removed request for a team October 2, 2024 08:30
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Oct 22, 2024
@bsmth
Copy link
Member Author

bsmth commented Nov 19, 2024

Thanks, Hamish. A couple of comments to have a look at, I think this is in a good state in general, what do you think?

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is in a good state in general, what do you think?

Yes :-). You've addressed all my concerns and this is clearly much better. Note that I didn't re-review everything here - just the stuff that was changed or referred to in resolved notes.

... and I did a few minor typo-style fixes/merged in a suggestion for wording of yours.

@hamishwillee hamishwillee merged commit f341bd4 into mdn:main Nov 22, 2024
8 checks passed
@bsmth bsmth deleted the http-messages-page branch November 22, 2024 08:50
@bsmth
Copy link
Member Author

bsmth commented Nov 22, 2024

Great, thanks a lot, Hamish 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants