Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-cn: init translation of cycletracker html css #15665

Merged
merged 10 commits into from
Sep 10, 2023

Conversation

hanyujie2002
Copy link
Contributor

@hanyujie2002 hanyujie2002 commented Sep 6, 2023

Description

same as title

Motivation

ditto

Additional details

None

Related issues and pull requests

Relates to #15548

@hanyujie2002 hanyujie2002 requested a review from a team as a code owner September 6, 2023 07:18
@hanyujie2002 hanyujie2002 requested review from yin1999 and removed request for a team September 6, 2023 07:18
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Preview URLs

Flaws (12)

URL: /zh-CN/docs/Web/Progressive_web_apps/Tutorials/CycleTracker/HTML_and_CSS
Title: 经期跟踪器:基础 HTML 和 CSS
Flaw count: 12

  • macros:
    • /zh-CN/docs/Glossary/accessible_name does not exist but fell back to /en-US/docs/Glossary/Accessible_name
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 6 more flaws omitted
External URLs (1)

URL: /zh-CN/docs/Web/Progressive_web_apps/Tutorials/CycleTracker/HTML_and_CSS
Title: 经期跟踪器:基础 HTML 和 CSS

(comment last updated: 2023-09-10 08:05:04)

hanyujie2002 and others added 2 commits September 6, 2023 15:36
…ml_and_css/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

我们的静态站点 HTML,用 {{HTMLElement("link")}} 和 {{HTMLElement("script")}} 元素作为尚未创建的外部 CSS 和 JavaScript 文件的占位符,如下:

```html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may not be a good idea to translate the example here, as the finished example below is not localized:

https://mdn.github.io/pwa-examples/cycletracker/html_and_css

/cc @jasonren0403 I think we need to discuss this with the core team members.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yin1999 Could we fork the pwa-examples repo and then create a localized edition of it?

Copy link
Contributor Author

@hanyujie2002 hanyujie2002 Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hanyujie2002. We do expect to see all examples be localized, but we are still discussing it with MDN staff, and we expect the localization of examples to get official support (such as create a repository of localized examples under the mdn organization).

Could we hold this PR for a while. I would be back as quick as we get the response from MDN staff :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hanyujie2002. We do expect to see all examples be localized, but we are still discussing it with MDN staff, and we expect the localization of examples to get official support (such as create a repository of localized examples under the mdn organization).

Could we hold this PR for a while. I would be back as quick as we get the response from MDN staff :)

OK 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, the result of our preliminary discussion is that for the samples with GitHub Live Sample, currently only translate the comments and other content that would not affect the resulting rendered page (or functionals) (the localization of other content/rendered live samples may be introduced together with the proposal here.

I believe it will take a long time to reach a consensus. So the current best practice is to only translate what doesn't affect the resulting page. Could you revert the localization which would affect the resulting page in this PR?

@hanyujie2002 hanyujie2002 requested a review from yin1999 September 7, 2023 08:55
@yin1999 yin1999 added the not ready Waiting on something else before this can be moved forward. label Sep 7, 2023
@yin1999 yin1999 removed the not ready Waiting on something else before this can be moved forward. label Sep 9, 2023
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions

@yin1999
Copy link
Member

yin1999 commented Sep 9, 2023

To locate the hash of headings, please follow the steps bellow:

  1. click the heading and copying from address bar

    image

  2. open the devtools and use the element selector to locate the element and determine the ids of elements.

    image

Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hanyujie2002 👍

@yin1999 yin1999 merged commit 86d0fd8 into mdn:main Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants