Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zh-cn: init translation of cycletracker html css #15665
zh-cn: init translation of cycletracker html css #15665
Changes from 1 commit
2519798
4e5eb4b
4e8a4e1
3a92c2e
7495e04
5db7f95
527da67
e80194a
d9eb42a
b8856bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may not be a good idea to translate the example here, as the finished example below is not localized:
/cc @jasonren0403 I think we need to discuss this with the core team members.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yin1999 Could we fork the pwa-examples repo and then create a localized edition of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have forked it and localize it, https://github.com/hanyujie2002/pwa-examples-zh-cn, please consider about it https://hanyujie2002.github.io/pwa-examples-zh-cn/cycletracker/html_and_css/index.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://hanyujie2002.github.io/pwa-examples-zh-cn/cycletracker/ all files have been localized now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hanyujie2002. We do expect to see all examples be localized, but we are still discussing it with MDN staff, and we expect the localization of examples to get official support (such as create a repository of localized examples under the mdn organization).
Could we hold this PR for a while. I would be back as quick as we get the response from MDN staff :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, the result of our preliminary discussion is that for the samples with GitHub Live Sample, currently only translate the comments and other content that would not affect the resulting rendered page (or functionals) (the localization of other content/rendered live samples may be introduced together with the proposal here.
I believe it will take a long time to reach a consensus. So the current best practice is to only translate what doesn't affect the resulting page. Could you revert the localization which would affect the resulting page in this PR?