Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh-cn: init the translation of mathml three famous formula #16684

Merged
merged 9 commits into from
Oct 28, 2023
Merged

zh-cn: init the translation of mathml three famous formula #16684

merged 9 commits into from
Oct 28, 2023

Conversation

hanyujie2002
Copy link
Contributor

Description

same as title

Motivation

ditto

Additional details

None

Related issues and pull requests

Relates to #16668

@hanyujie2002 hanyujie2002 requested a review from a team as a code owner October 23, 2023 15:17
@hanyujie2002 hanyujie2002 requested review from t7yang and removed request for a team October 23, 2023 15:17
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Oct 23, 2023
@hanyujie2002 hanyujie2002 mentioned this pull request Oct 23, 2023
Closed
8 tasks
github-actions[bot]
github-actions bot reviewed Oct 23, 2023
View reviewed changes
files/zh-cn/learn/mathml/first_steps/three_famous_mathematical_formulas/index.md Show resolved Hide resolved
files/zh-cn/learn/mathml/first_steps/three_famous_mathematical_formulas/index.md Show resolved Hide resolved
files/zh-cn/learn/mathml/first_steps/three_famous_mathematical_formulas/index.md Show resolved Hide resolved
files/zh-cn/learn/mathml/first_steps/three_famous_mathematical_formulas/index.md Show resolved Hide resolved
files/zh-cn/learn/mathml/first_steps/three_famous_mathematical_formulas/index.md Show resolved Hide resolved
files/zh-cn/learn/mathml/first_steps/three_famous_mathematical_formulas/index.md Show resolved Hide resolved
files/zh-cn/learn/mathml/first_steps/three_famous_mathematical_formulas/index.md Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023 •
edited
Loading

Preview URLs

Flaws (48)

URL: /zh-CN/docs/Learn/MathML/First_steps/Three_famous_mathematical_formulas
Title: 三个著名的数学公式
Flaw count: 48

  • macros:
    • /zh-CN/docs/Learn/Tools_and_testing/Understanding_client-side_tools/Deployment does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Understanding_client-side_tools/Deployment
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_resources does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_resources
    • and 43 more flaws omitted
External URLs (4)

URL: /zh-CN/docs/Learn/MathML/First_steps/Three_famous_mathematical_formulas
Title: 三个著名的数学公式

(comment last updated: 2023-10-28 09:08:41)

@hanyujie2002 hanyujie2002 requested a review from yin1999 October 24, 2023 05:02
@hanyujie2002 hanyujie2002 requested a review from yin1999 October 26, 2023 08:51
@yin1999
Copy link
Member

yin1999 commented Oct 26, 2023

Please run filecheck tool in content dir to compress the image. I can't merge this PR until all the ci tests passed.

https://github.com/mdn/translated-content/actions/runs/6651719973/job/18074298860?pr=16684

yin1999
yin1999 reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost looks good. Just some suggestions:

files/zh-cn/learn/mathml/first_steps/three_famous_mathematical_formulas/index.md Outdated Show resolved Hide resolved
files/zh-cn/learn/mathml/first_steps/three_famous_mathematical_formulas/index.md Outdated Show resolved Hide resolved
files/zh-cn/learn/mathml/first_steps/three_famous_mathematical_formulas/index.md Outdated Show resolved Hide resolved
files/zh-cn/learn/mathml/first_steps/three_famous_mathematical_formulas/index.md Outdated Show resolved Hide resolved
@hanyujie2002 hanyujie2002 requested a review from yin1999 October 28, 2023 09:06
yin1999
yin1999 approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hanyujie2002

@yin1999 yin1999 changed the title zh-cn: init localization of mathml three famous formula zh-cn: init the translation of mathml three famous formula Oct 28, 2023
@yin1999 yin1999 merged commit eb3caa8 into mdn:main Oct 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@yin1999 yin1999 yin1999 approved these changes

@t7yang t7yang Awaiting requested review from t7yang t7yang is a code owner automatically assigned from mdn/yari-content-zh

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanyujie2002 @yin1999 @jasonren0403