Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] add sidebar to Glossary pages (part 6) #17036

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

leon-win
Copy link
Member

@leon-win leon-win commented Nov 19, 2023

Description

Add sidebar (with list of terms) to all Glossary pages in Japanese locale (part 6).

Motivation

Sidebar is useful for navigation in Glossary, so this change will improve user experience.

Related issues and pull requests

Part of: #16942
Relates to #16863, #16943, #16970, #17031, #17032, #17033, #17034, #17035

@leon-win leon-win requested a review from a team as a code owner November 19, 2023 21:41
@leon-win leon-win requested review from kenji-yamasaki and removed request for a team November 19, 2023 21:41
@github-actions github-actions bot added the l10n-ja Issues related to Japanese content. label Nov 19, 2023
Copy link
Contributor

github-actions bot commented Nov 19, 2023

Preview URLs (24 pages)
Flaws (16)

Note! 13 documents with no flaws that don't need to be listed. 🎉

URL: /ja/docs/Glossary
Title: MDN Web Docs 用語集: ウェブ関連用語の定義
Flaw count: 1

  • broken_links:
    • Can't resolve /ja/docs/MDN/Contribute/Howto/Write_a_new_entry_in_the_Glossary

URL: /ja/docs/Glossary/XML
Title: XML
Flaw count: 1

  • broken_links:
    • Can't resolve /ja/docs/XML_Introduction

URL: /ja/docs/Glossary/XMLHttpRequest
Title: XHR (XMLHttpRequest)
Flaw count: 1

  • broken_links:
    • Can't resolve /ja/docs/Web/API/XMLHttpRequest/Using_XMLHttpRequest

URL: /ja/docs/Glossary/XPath
Title: XPath
Flaw count: 2

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /ja/docs/Glossary/XHTML
Title: XHTML
Flaw count: 1

  • broken_links:
    • Can't resolve /ja/docs/Web/Guide/HTML/XHTML

URL: /ja/docs/Glossary/World_Wide_Web
Title: World Wide Web
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /ja/docs/Glossary/WebIDL
Title: WebIDL
Flaw count: 4

  • macros:
    • /ja/docs/Glossary/interface does not exist
  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /ja/docs/MDN/Contribute/Howto/Write_an_API_reference/Information_contained_in_a_WebIDL_file
    • Can't resolve /ja/docs/Mozilla/WebIDL_bindings

URL: /ja/docs/Glossary/WebSockets
Title: WebSockets
Flaw count: 2

  • broken_links:
    • Can't resolve /ja/docs/WebSockets/Writing_WebSocket_client_applications
    • Can use the English (en-US) link as a fallback

URL: /ja/docs/Glossary/WebGL
Title: WebGL
Flaw count: 1

  • broken_links:
    • Can't resolve /ja/docs/Web/WebGL

URL: /ja/docs/Glossary/WebKit
Title: WebKit
Flaw count: 1

  • broken_links:
    • Can use the English (en-US) link as a fallback

URL: /ja/docs/Glossary/WebVTT
Title: WebVTT
Flaw count: 1

  • broken_links:
    • Can't resolve /ja/docs/Web/API/Web_Video_Text_Tracks_Format

(comment last updated: 2023-11-21 09:34:44)

Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@mfuji09 mfuji09 merged commit c6b60dd into mdn:main Nov 24, 2023
7 checks passed
@leon-win leon-win deleted the fix/16942/ja-glossary-sidebar-part-6 branch November 24, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ja Issues related to Japanese content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants