Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] fix: NOTE syntax #23373

Merged
merged 5 commits into from
Sep 8, 2024
Merged

[ko] fix: NOTE syntax #23373

merged 5 commits into from
Sep 8, 2024

Conversation

hochan222
Copy link
Member

@hochan222 hochan222 commented Sep 4, 2024

Description

> [!NOTE]은 새로 추가된 github markdown으로 영어로만 사용 가능합니다.

AS IS

> [!참고] 

TO BE

> [!NOTE] 

[Markdown] An option to highlight a "Note" and "Warning" using blockquote (Beta)

cc. @mdn/yari-content-ko , @givvemee

Related issues and pull requests

#22796

@hochan222 hochan222 requested a review from a team as a code owner September 4, 2024 04:04
@hochan222 hochan222 requested review from yechoi42 and removed request for a team September 4, 2024 04:04
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Preview URLs

Flaws (5)

URL: /ko/docs/Web/CSS/Namespace_separator
Title: Namespace separator
Flaw count: 2

  • macros:
    • /ko/docs/Web/API/Document/createElementNS does not exist but fell back to /en-US/docs/Web/API/Document/createElementNS
    • /ko/docs/Web/API/Document/createElementNS does not exist but fell back to /en-US/docs/Web/API/Document/createElementNS

URL: /ko/docs/Web/CSS/:blank
Title: :blank
Flaw count: 3

  • macros:
    • /ko/docs/Web/HTML/Element/input does not exist but fell back to /en-US/docs/Web/HTML/Element/input
    • /ko/docs/Web/HTML/Element/textarea does not exist but fell back to /en-US/docs/Web/HTML/Element/textarea
    • /ko/docs/Web/CSS/:empty does not exist but fell back to /en-US/docs/Web/CSS/:empty

(comment last updated: 2024-09-04 04:31:12)

Comment on lines +10 to +11
> [!NOTE]
> `:blank` 선택자는 CSSWG가 지속적으로 변경하고 있음에 따라 위험 요소로 간주됩니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change
> [!NOTE]
> `:blank` 선택자는 CSSWG가 지속적으로 변경하고 있음에 따라 위험 요소로 간주됩니다.
> [!NOTE] > `:blank` 선택자는 CSSWG가 지속적으로 변경하고 있음에 따라 위험 요소로 간주됩니다.

@hochan222
Copy link
Member Author

hochan222 commented Sep 4, 2024

Hello, @queengooborg.

A markdown lint error occurred even though the content is identical to GFM Alerts. Do you have any guesses as to what the problem might be?

mdn/content (en-us)

> [!NOTE]
> The `:blank` selector is considered at risk, as the CSSWG keeps changing it.
>
> See [CSSWG issue #1967](https://github.com/w3c/csswg-drafts/issues/1967).

@queengooborg
Copy link
Collaborator

This is because of a Prettier bug, unfortunately, where if the first character of the first line after the magic keyword is a special character (`, *, etc.), it combines the first and second lines. For now, these blocks will have to use the original MDN syntax, until the issue is resolved in Prettier.

@hochan222 hochan222 requested review from wisedog and removed request for yechoi42 September 4, 2024 04:23
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@hochan222
Copy link
Member Author

hochan222 commented Sep 4, 2024

@queengooborg I understand. Thank you. Have a great day :)

@wisedog 안녕하세요~!

prettier 오류로 린트 "prettier/prettier#16454" 수정 전까지 린트 수정하지 않고 병합해도 좋을 듯합니다.

@givvemee
Copy link
Contributor

givvemee commented Sep 4, 2024

오! 감사합니다.
이전에 이렇게 번역한 것들이 몇 개 있었던 것 같은데 ... 시간 내서 다시 NOTE 로 되돌리는 PR 을 올려볼게요.

@hochan222 hochan222 merged commit 9ece650 into mdn:main Sep 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants