Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh-CN: create sidebarAction.setIcon() #24900

Merged
merged 11 commits into from
Dec 22, 2024
Merged

zh-CN: create sidebarAction.setIcon() #24900

merged 11 commits into from
Dec 22, 2024
+116 −0

Conversation

PassionPenguin
Copy link
Contributor

No description provided.

@PassionPenguin PassionPenguin requested a review from a team as a code owner December 2, 2024 05:13
@PassionPenguin PassionPenguin requested review from yin1999 and removed request for a team December 2, 2024 05:13
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

Preview URLs

Flaws (13)

URL: /zh-CN/docs/Mozilla/Add-ons/WebExtensions/API/sidebarAction/setIcon
Title: sidebarAction.setIcon()
Flaw count: 13

  • macros:
    • /zh-CN/docs/Mozilla/Add-ons/WebExtensions/Background_scripts does not exist but fell back to /en-US/docs/Mozilla/Add-ons/WebExtensions/Background_scripts
    • /zh-CN/docs/Mozilla/Add-ons/WebExtensions/Working_with_files does not exist but fell back to /en-US/docs/Mozilla/Add-ons/WebExtensions/Working_with_files
    • /zh-CN/docs/Mozilla/Add-ons/WebExtensions/Differences_between_API_implementations does not exist but fell back to /en-US/docs/Mozilla/Add-ons/WebExtensions/Differences_between_API_implementations
    • /zh-CN/docs/Mozilla/Add-ons/WebExtensions/user_interface/Sidebars does not exist but fell back to /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Sidebars
    • /zh-CN/docs/Mozilla/Add-ons/WebExtensions/user_interface/Context_menu_items does not exist but fell back to /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Context_menu_items
    • and 8 more flaws omitted
External URLs (1)

URL: /zh-CN/docs/Mozilla/Add-ons/WebExtensions/API/sidebarAction/setIcon
Title: sidebarAction.setIcon()

(comment last updated: 2024-12-22 10:51:30)

yin1999
yin1999 requested changes Dec 18, 2024
View reviewed changes
files/zh-cn/mozilla/add-ons/webextensions/api/sidebaraction/seticon/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/sidebaraction/seticon/index.md Outdated

你可以通过提供一个包含多个路径或 `ImageData` 对象的字典来指定多个不同尺寸的图标，这样图标就不必为具有不同像素密度的设备进行缩放。

这是一个异步函数，返回一个 [`Promise`](/zh-CN/docs/Web/JavaScript/Reference/Global_Objects/Promise)。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前指出过怎么改了，请修正

files/zh-cn/mozilla/add-ons/webextensions/api/sidebaraction/seticon/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/sidebaraction/seticon/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/sidebaraction/seticon/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/sidebaraction/seticon/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/sidebaraction/seticon/index.md Outdated Show resolved Hide resolved
PassionPenguin
PassionPenguin commented Dec 21, 2024
View reviewed changes
files/zh-cn/mozilla/add-ons/webextensions/api/sidebaraction/seticon/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/sidebaraction/seticon/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/sidebaraction/seticon/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/sidebaraction/seticon/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/sidebaraction/seticon/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/sidebaraction/seticon/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/sidebaraction/seticon/index.md Outdated Show resolved Hide resolved
files/zh-cn/mozilla/add-ons/webextensions/api/sidebaraction/seticon/index.md Outdated Show resolved Hide resolved
@PassionPenguin PassionPenguin mentioned this pull request Dec 21, 2024
Merged
@PassionPenguin PassionPenguin marked this pull request as draft December 21, 2024 13:17
@PassionPenguin PassionPenguin marked this pull request as ready for review December 22, 2024 10:32
yin1999
yin1999 approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yin1999 yin1999 enabled auto-merge (squash) December 22, 2024 10:50
@yin1999 yin1999 merged commit 33e0f94 into mdn:main Dec 22, 2024
6 checks passed
@PassionPenguin PassionPenguin deleted the sidebaraction-3 branch December 22, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@yin1999 yin1999 yin1999 approved these changes

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
MDN translated-content l10n-zh
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PassionPenguin @yin1999