-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja]: auto-fix links #25032
[ja]: auto-fix links #25032
Conversation
Preview URLs (300 pages)
Flaws (3186)Note! 74 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
TRUNCATED! |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has too many files to review at once.
Please split this PR into several PRs which have less than 100 files.
Please refer to https://developer.mozilla.org/en-US/docs/MDN/Community/Pull_requests#open_a_pull_request,
This pull request has merge conflicts that must be resolved before it can be merged. |
@mfuji09 Thanks for looking at this. This PR does two things.
You can look at the actual differences in the diff We want to have single PR's per locale to keep the noise down and to be able to revert if anything happens (we have it on stage an we didn't see any issues). We want go ahead with this as this is more of an platform change than content. We are happy to help with any inconvenience this might create. |
@fiji-flo |
Sorry for that, yes GitHub is not great at this. Feel free to push to this PR and/or we just talk on discord in the #mdn-platform-🌐 channel? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're merging this since otherwise links on production will break. |
Description
This fixes plain markdown links to point to the actual destination without going through the whole redirect stack.
(MP-1798)
Motivation
To continue our transition to rari, we have to weed out any links in documentation that rely on "fundamental redirects". Fundamental redirects (as opposed to our main redirect map) are only there to support requests coming in from really outdated links on the internet.
Additional details
Luckily, yari already has tooling around fixing those links, so this is basically a version of translated content with the fix-flaws/broken-links tooling applied. The result looks very good, and even shows improvements on linking less often to the en-US content when there is a translated version of the page available.
Using the rari diff tool, I have attached a HTML file that highlights all differences before/after the change on the simplified HTML rendering of the content.
Diffs.zip