chore(macros): remove "Inheritance" from JS sidebars #8269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
|
See: #8052 (comment). I don't really want to remove this, unless a better solution can't exist. The existing one is bad, but at least its badness reminds us to explore what would be better, |
|
See #8502 |
|
Closing in favor of #8502. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the "Inheritance" section in the JavaScript sidebars (
APIRefandJSSidebar), as agreed upon at the Mozilla/OWD meetup.Fixes #8052.
Problem
The section is not particularly useful and makes the sidebars longer than necessary.
Solution
Remove it.
Screenshots
Before
After
How did you test this change?
Ran
yarn devand then:APIRefsidebar, I opened http://localhost:3000/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array locally.JSRefsidebar, I opened http://localhost:3000/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakMap locally.