enhance(macros/JSRef): refactor + update inheritance data + separate instance/static methods/properties #8502
Conversation
kumascript/macros/JSRef.ejs
Outdated
| if (group.length > 0) { | ||
| output += `<li><strong>${text.Related}</strong></li>`; | ||
| for (const groupItem of group) { | ||
| const link = web.smartLink( | ||
| `${slugStdlib}/${groupItem.replace(".", "/")}`, | ||
| null, | ||
| `<code>${groupItem}</code>`, | ||
| null, | ||
| slugStdlib, | ||
| "JSRef", | ||
| ); | ||
| output += `<li><strong>${link}</strong></li>`; |
There was a problem hiding this comment.
Because the inheritance chain is now proper, there's less need for the "related pages" part (except for Intl, where navigation remains a bit awkward). I've thus put it below "inheritance" to avoid obstructing the more structured information.
Josh-Cena
force-pushed
the
improv-jsref
branch
2 times, most recently
from
6a7bf17 to
dd0c1ab
Compare
|
cc @wbamberg in case you missed it—this should interest you |
caugner
changed the title
caugner
changed the title
github-actions
bot
added
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
There was a problem hiding this comment.
LGTU (@argl @fiji-flo @caugner) and is currently deployed at https://developer.allizom.xyz/, thanks a lot.
We'll loop in the MDN content team once more before merging.
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
|
Thank you @Josh-Cena! 🙌 |
|
Nice! Thanks! |
Summary
Fix #8052. This should replace #8269.
Problem
The inheritance is useless; static properties/methods and instance properties/methods are not differentiated.
Solution
This PR is a total refactor of the
JSRefimplementation. With this change, I hope the sidebar can be more useful.Screenshots
How did you test this change?