Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFRA-468: Update workflow-cps-global-lib,docker-commons,pipeline-stage-view,jira #48

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

enyachoke
Copy link
Collaborator

@enyachoke enyachoke commented Jul 11, 2024

Update more plugins as part of INFRA-468

And add sudo to sed to resolve permission issue when deploying dockerComposeFromArtifact project tyoe

@enyachoke enyachoke requested a review from rbuisson July 15, 2024 12:07
@@ -711,7 +711,7 @@ module.exports = {

// 'sed' will need an escaped string at runtime. Escaping.
var valueEscaped = value.replace(/\//g, "\\/");
script += `\tsed -i "s/^[#]*\\s*${propertyName}\\b.*/${propertyName}=${valueEscaped}/" ${filename}\n`;
script += `\tsudo sed -i "s/^[#]*\\s*${propertyName}\\b.*/${propertyName}=${valueEscaped}/" ${filename}\n`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird. Do you know the underlying reason for needing sudo to run sed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, but without it, we have this failure
image

@enyachoke enyachoke merged commit 4a492e5 into mekomsolutions:master Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants