Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFRA-468: Update workflow-cps-global-lib,docker-commons,pipeline-stage-view,jira #48

Merged
merged 3 commits into from
Aug 28, 2024
Merged

INFRA-468: Update workflow-cps-global-lib,docker-commons,pipeline-stage-view,jira #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c995e5
INFRA-468: Update workflow-cps-global-lib,docker-commons,pipeline-sta…
enyachoke Jul 11, 2024
ca49929
Add sudo to sed
enyachoke Jul 11, 2024
8b83de0
Fix test
enyachoke Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion docker/config/plugins.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,9 @@ simple-theme-plugin:191.vcd207ef9dd24
login-theme:1.1
blueocean:1.27.13
maven-plugin:3.16
google-login:109.v022b_cf87b_e5b_
google-login:109.v022b_cf87b_e5b_
workflow-cps-global-lib:612.v55f2f80781ef
docker-commons:439.va_3cb_0a_6a_fb_29
git-server:126.v0d945d8d2b_39
pipeline-stage-view:2.34
jira:3.13
2 changes: 1 addition & 1 deletion node-scripts/spec/pipeline3/scripts.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ describe("Scripts", function() {
'\techo "KEY=a/path/on/the/disk" >> .env\n' +
"else\n" +
"\techo \"'KEY' is found in file '.env'. Updating...\"\n" +
'\tsed -i "s/^[#]*\\s*KEY\\b.*/KEY=a\\/path\\/on\\/the\\/disk/" .env\n' +
'\tsudo sed -i "s/^[#]*\\s*KEY\\b.*/KEY=a\\/path\\/on\\/the\\/disk/" .env\n' +
"fi\n"
);
});
Expand Down
2 changes: 1 addition & 1 deletion node-scripts/src/pipeline3/scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,7 @@ module.exports = {

// 'sed' will need an escaped string at runtime. Escaping.
var valueEscaped = value.replace(/\//g, "\\/");
script += `\tsed -i "s/^[#]*\\s*${propertyName}\\b.*/${propertyName}=${valueEscaped}/" ${filename}\n`;
script += `\tsudo sed -i "s/^[#]*\\s*${propertyName}\\b.*/${propertyName}=${valueEscaped}/" ${filename}\n`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird. Do you know the underlying reason for needing sudo to run sed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, but without it, we have this failure
image

script += "fi\n";
return script;
},
Expand Down
Loading