Fix XML information in GdbCmds.cpp and add support for the 'vCont;' command. #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSDuck
reviewed
Aug 3, 2024
| @@ -46,7 +46,7 @@ const char* TARGET_INFO_ARM9 = "cputype:12;cpusubtype:7;triple:arm-none-eabi;ost | |||
| "<reg name=\"r11\" bitsize=\"32\" type=\"uint32\"/>" \ | |||
| "<reg name=\"r12\" bitsize=\"32\" type=\"uint32\"/>" \ | |||
| "<reg name=\"sp\" bitsize=\"32\" type=\"data_ptr\"/>" \ | |||
| "<reg name=\"lr\" bitsize=\"32\" type=\"code_ptr\"/>" \ | |||
There was a problem hiding this comment.
lr definitely points to code (most of the time)?
There was a problem hiding this comment.
The situation is like this: when using IDA Pro for debugging, its view will follow the first register of type code_ptr. In the previous code, it would follow the lr register, causing issues with the view display during debugging.
There was a problem hiding this comment.
That does sound kind of stupid, though I guess you could move pc up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previously encountered some issues when trying to debug with GDB provided by IDA Pro while connecting to melonDS. I made corrections to address these issues, and after the fixes, debugging in IDA Pro works as shown in the image below. Additionally, I noticed some bugs in the GDB-related configurations in the .toml file, but I am unsure how to fix them properly.
