Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XML information in GdbCmds.cpp and add support for the 'vCont;' command. #2074

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix XML information in GdbCmds.cpp and add support for the 'vCont;' command. #2074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/debug/GdbCmds.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const char* TARGET_INFO_ARM9 = "cputype:12;cpusubtype:7;triple:arm-none-eabi;ost
"<reg name=\"r11\" bitsize=\"32\" type=\"uint32\"/>" \
"<reg name=\"r12\" bitsize=\"32\" type=\"uint32\"/>" \
"<reg name=\"sp\" bitsize=\"32\" type=\"data_ptr\"/>" \
"<reg name=\"lr\" bitsize=\"32\" type=\"code_ptr\"/>" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lr definitely points to code (most of the time)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The situation is like this: when using IDA Pro for debugging, its view will follow the first register of type code_ptr. In the previous code, it would follow the lr register, causing issues with the view display during debugging.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does sound kind of stupid, though I guess you could move pc up?

"<reg name=\"lr\" bitsize=\"32\"/>" \
"<reg name=\"pc\" bitsize=\"32\" type=\"code_ptr\"/>" \
/* 16 regs */ \

Expand Down
1 change: 1 addition & 0 deletions src/debug/GdbStub.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ SubcmdHandler GdbStub::Handlers_v[] = {
{ .MainCmd = 'v', .SubStr = "Stopped" , .Handler = GdbStub::Handle_v_Stopped },
{ .MainCmd = 'v', .SubStr = "MustReplyEmpty", .Handler = GdbStub::Handle_v_MustReplyEmpty },
{ .MainCmd = 'v', .SubStr = "Cont?" , .Handler = GdbStub::Handle_v_ContQuery },
{ .MainCmd = 'v', .SubStr = "Cont;" , .Handler = GdbStub::Handle_v_Cont },
{ .MainCmd = 'v', .SubStr = "Cont" , .Handler = GdbStub::Handle_v_Cont },

{ .MainCmd = 'v', .SubStr = NULL, .Handler = NULL }
Expand Down