Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom resolver for map definition #79

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Fix custom resolver for map definition #79

merged 2 commits into from
Dec 8, 2023

Conversation

goccy
Copy link
Member

@goccy goccy commented Dec 8, 2023

Fix bug that custom resolver list was incomplete when map or validation was defined

Copy link

github-actions bot commented Dec 8, 2023

Code Metrics Report

main (9ecaa0d) #79 (785f1e3) +/-
Coverage 65.6% 65.6% -0.0%
Code to Test Ratio 1:0.4 1:0.4 -0.0
Test Execution Time 3m19s 3m20s +1s
Details
  |                     | main (9ecaa0d) | #79 (785f1e3) |  +/-  |
  |---------------------|----------------|---------------|-------|
- | Coverage            |          65.6% |         65.6% | -0.0% |
  |   Files             |             60 |            60 |     0 |
  |   Lines             |           8713 |          8718 |    +5 |
+ |   Covered           |           5713 |          5715 |    +2 |
- | Code to Test Ratio  |          1:0.4 |         1:0.4 |  -0.0 |
  |   Code              |          25491 |         25517 |   +26 |
+ |   Test              |          11137 |         11146 |    +9 |
- | Test Execution Time |          3m19s |         3m20s |   +1s |

Code coverage of files in pull request scope (85.3% → 85.0%)

Files Coverage +/-
internal/testutil/builder.go 85.0% -0.3%
resolver/message.go 85.1% -0.2%

Reported by octocov

Copy link
Contributor

@shuheiktgw shuheiktgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙆‍♂️

@goccy goccy merged commit 69e5270 into main Dec 8, 2023
4 checks passed
@goccy goccy deleted the fix-custom-resolver branch December 8, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants