Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom resolver for map definition #79

Merged
merged 2 commits into from
Dec 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions generator/testdata/expected_map.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions internal/testutil/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -1218,6 +1218,13 @@ func NewFieldRuleBuilder(value *resolver.Value) *FieldRuleBuilder {
return &FieldRuleBuilder{rule: &resolver.FieldRule{Value: value}}
}

func (b *FieldRuleBuilder) SetAutoBind(field *resolver.Field) *FieldRuleBuilder {
b.rule.AutoBindField = &resolver.AutoBindField{
Field: field,
}
return b
}

func (b *FieldRuleBuilder) SetCustomResolver(v bool) *FieldRuleBuilder {
b.rule.CustomResolver = v
return b
Expand Down
9 changes: 7 additions & 2 deletions resolver/message.go
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,13 @@ func (m *Message) CustomResolvers() []*CustomResolver {

func (m *Message) customResolvers(resolver *MessageResolver) []*CustomResolver {
var ret []*CustomResolver
if def := resolver.VariableDefinition; def != nil && def.Expr.Message != nil {
ret = append(ret, def.Expr.Message.Message.CustomResolvers()...)
if def := resolver.VariableDefinition; def != nil {
for _, expr := range def.MessageExprs() {
if expr.Message == nil {
continue
}
ret = append(ret, expr.Message.CustomResolvers()...)
}
}
return ret
}
Expand Down
13 changes: 11 additions & 2 deletions resolver/resolver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3187,8 +3187,16 @@ func TestMap(t *testing.T) {
).
AddMessage(
testutil.NewMessageBuilder("User").
AddFieldWithAutoBind("id", resolver.StringType, ref.Field(t, "org.user", "User", "id")).
AddFieldWithAutoBind("name", resolver.StringType, ref.Field(t, "org.user", "User", "name")).
AddFieldWithRule(
"id",
resolver.StringType,
testutil.NewFieldRuleBuilder(nil).SetMessageCustomResolver(true).Build(t),
).
AddFieldWithRule(
"name",
resolver.StringType,
testutil.NewFieldRuleBuilder(nil).SetMessageCustomResolver(true).Build(t),
).
SetRule(
testutil.NewMessageRuleBuilder().
AddVariableDefinition(
Expand Down Expand Up @@ -3219,6 +3227,7 @@ func TestMap(t *testing.T) {
SetBy(testutil.NewCELValueBuilder("res.user", ref.Type(t, "org.user", "User")).Build(t)).
Build(t),
).
SetCustomResolver(true).
SetMessageArgument(ref.Message(t, "org.federation", "UserArgument")).
SetDependencyGraph(
testutil.NewDependencyGraphBuilder().
Expand Down
1 change: 1 addition & 0 deletions testdata/map.proto
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ message User {
}
}
def { name: "user" by: "res.user" autobind: true }
custom_resolver: true
};
string id = 1;
string name = 2;
Expand Down
Loading