Skip to content

Commit

Permalink
Use more standard l_mb_server name
Browse files Browse the repository at this point in the history
This was blocked by eslint but we have exceptions for all others,
and looks a lot more readable than lMbServer (and related names)
  • Loading branch information
reosarevok committed Jan 17, 2025
1 parent c4682c0 commit de73f2d
Show file tree
Hide file tree
Showing 11 changed files with 139 additions and 132 deletions.
3 changes: 3 additions & 0 deletions .eslintrc.unfixed.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ rules:
"l_languages",
"ln_languages",
"lp_languages",
"l_mb_server",
"lp_mb_server",
"l_relationships",
"ln_relationships",
"lp_relationships",
Expand All @@ -34,6 +36,7 @@ rules:
"N_l",
"N_ln",
"N_lp",
"N_l_mb_server",
"N_l_statistics",
"N_lp_statistics",
"__webpack_public_path__",
Expand Down
3 changes: 3 additions & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,8 @@ export default [
'l_languages',
'ln_languages',
'lp_languages',
'l_mb_server',
'lp_mb_server',
'l_relationships',
'ln_relationships',
'lp_relationships',
Expand All @@ -234,6 +236,7 @@ export default [
'N_l',
'N_ln',
'N_lp',
'N_l_mb_server',
'N_l_statistics',
'N_lp_statistics',
'__webpack_public_path__',
Expand Down
14 changes: 7 additions & 7 deletions root/statistics/Countries.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import * as React from 'react';
import {CatalystContext} from '../context.mjs';
import manifest from '../static/manifest.mjs';
import EntityLink from '../static/scripts/common/components/EntityLink.js';
import {l as lMbServer} from '../static/scripts/common/i18n.js';
import {l as l_mb_server} from '../static/scripts/common/i18n.js';
import loopParity from '../utility/loopParity.js';

import StatisticsLayout from './StatisticsLayout.js';
Expand Down Expand Up @@ -48,27 +48,27 @@ component Countries(
<tr>
<th className="pos">{l_statistics('Rank')}</th>
<th>
{lMbServer('Country')}
{l_mb_server('Country')}
<div className="arrow" />
</th>
<th>
{lMbServer('Artists')}
{l_mb_server('Artists')}
<div className="arrow" />
</th>
<th>
{lMbServer('Releases')}
{l_mb_server('Releases')}
<div className="arrow" />
</th>
<th>
{lMbServer('Labels')}
{l_mb_server('Labels')}
<div className="arrow" />
</th>
<th>
{lMbServer('Events')}
{l_mb_server('Events')}
<div className="arrow" />
</th>
<th>
{lMbServer('Places')}
{l_mb_server('Places')}
<div className="arrow" />
</th>
<th>
Expand Down
8 changes: 4 additions & 4 deletions root/statistics/Editors.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import * as React from 'react';

import {CatalystContext} from '../context.mjs';
import EditorLink from '../static/scripts/common/components/EditorLink.js';
import {l as lMbServer} from '../static/scripts/common/i18n.js';
import {l as l_mb_server} from '../static/scripts/common/i18n.js';
import loopParity from '../utility/loopParity.js';

import StatisticsLayout from './StatisticsLayout.js';
Expand Down Expand Up @@ -86,7 +86,7 @@ component Editors(
<StatisticsLayout
fullWidth
page="editors"
title={lMbServer('Editors')}
title={l_mb_server('Editors')}
>
<p>
{texp.l_statistics('Last updated: {date}', {date: dateCollected})}
Expand All @@ -102,13 +102,13 @@ component Editors(
<EditorStatsTable
countLabel={l_statistics('Open and applied edits in past week')}
dataPoints={topRecentlyActiveEditors}
editorLabel={lMbServer('Editor')}
editorLabel={l_mb_server('Editor')}
tableLabel={l_statistics('Most active editors in the past week')}
/>
<EditorStatsTable
countLabel={l_statistics('Total applied edits')}
dataPoints={topEditors}
editorLabel={lMbServer('Editor')}
editorLabel={l_mb_server('Editor')}
tableLabel={l_statistics('Top editors overall')}
/>
</div>
Expand Down
4 changes: 2 additions & 2 deletions root/statistics/Edits.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import * as React from 'react';

import LinkSearchableEditType from '../components/LinkSearchableEditType.js';
import {CatalystContext} from '../context.mjs';
import {l as lMbServer} from '../static/scripts/common/i18n.js';
import {l as l_mb_server} from '../static/scripts/common/i18n.js';

import StatisticsLayout from './StatisticsLayout.js';
import {formatCount, formatPercentage, TimelineLink} from './utilities.js';
Expand All @@ -32,7 +32,7 @@ component Edits(
<p>
{texp.l_statistics('Last updated: {date}', {date: dateCollected})}
</p>
<h2>{lMbServer('Edits')}</h2>
<h2>{l_mb_server('Edits')}</h2>
{Object.keys(statsByCategory).length === 0 ? (
<p>
{l_statistics('No edit statistics available.')}
Expand Down
8 changes: 4 additions & 4 deletions root/statistics/Formats.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import * as React from 'react';

import LinkSearchableProperty from '../components/LinkSearchableProperty.js';
import {CatalystContext} from '../context.mjs';
import {l as lMbServer} from '../static/scripts/common/i18n.js';
import {l as l_mb_server} from '../static/scripts/common/i18n.js';
import loopParity from '../utility/loopParity.js';

import StatisticsLayout from './StatisticsLayout.js';
Expand Down Expand Up @@ -47,10 +47,10 @@ component Formats(
<thead>
<tr>
<th className="pos">{l_statistics('Rank')}</th>
<th>{lMbServer('Format')}</th>
<th>{lMbServer('Releases')}</th>
<th>{l_mb_server('Format')}</th>
<th>{l_mb_server('Releases')}</th>
<th>{l_statistics('% of total releases')}</th>
<th>{lMbServer('Mediums')}</th>
<th>{l_mb_server('Mediums')}</th>
<th>{l_statistics('% of total mediums')}</th>
</tr>
</thead>
Expand Down
Loading

0 comments on commit de73f2d

Please sign in to comment.