-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[R-package] added R linting and changed R code to comma-first (fixes #…
- Loading branch information
Showing
63 changed files
with
1,819 additions
and
1,007 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
|
||
library(lintr) | ||
|
||
args <- commandArgs( | ||
trailingOnly = TRUE | ||
) | ||
SOURCE_DIR <- args[[1]] | ||
|
||
FILES_TO_LINT <- list.files( | ||
path = SOURCE_DIR | ||
, pattern = "\\.r$" | ||
, all.files = TRUE | ||
, ignore.case = TRUE | ||
, full.names = TRUE | ||
, recursive = TRUE | ||
, include.dirs = FALSE | ||
) | ||
|
||
# Some linters from the lintr package have not made it to CRAN yet | ||
# We build lintr from source to address that. | ||
LINTERS_TO_USE <- list( | ||
"closed_curly" = lintr::closed_curly_linter | ||
, "infix_spaces" = lintr::infix_spaces_linter | ||
, "long_lines" = lintr::line_length_linter(length = 120) | ||
, "tabs" = lintr::no_tab_linter | ||
, "open_curly" = lintr::open_curly_linter | ||
, "spaces_inside" = lintr::spaces_inside_linter | ||
, "spaces_left_parens" = lintr::spaces_left_parentheses_linter | ||
, "trailing_blank" = lintr::trailing_blank_lines_linter | ||
, "trailing_white" = lintr::trailing_whitespace_linter | ||
) | ||
|
||
cat(sprintf("Found %i R files to lint\n", length(FILES_TO_LINT))) | ||
|
||
results <- c() | ||
|
||
for (r_file in FILES_TO_LINT){ | ||
|
||
this_result <- lintr::lint( | ||
filename = r_file | ||
, linters = LINTERS_TO_USE | ||
, cache = FALSE | ||
) | ||
|
||
cat(sprintf( | ||
"Found %i linting errors in %s\n" | ||
, length(this_result) | ||
, r_file | ||
)) | ||
|
||
results <- c(results, this_result) | ||
|
||
} | ||
|
||
issues_found <- length(results) | ||
|
||
if (issues_found > 0){ | ||
cat("\n") | ||
print(results) | ||
} | ||
|
||
quit(save = "no", status = issues_found) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.