Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows GPU wheels #3143

Closed
wants to merge 26 commits into from
Closed

Conversation

itamarst
Copy link
Contributor

@itamarst itamarst commented Jun 3, 2020

Fixes #2263.

This builds on top of #3144, so that'll need to get merged first. Once that is merged, it will be possible to create a single wheel on Windows that work with both CPU and GPU devices. This PR then changes the CI build process to actually use that functionality, so that the standard Windows wheels will work on GPU devices too.

Unlike my previous attempt, the same wheel should work on both GPU and CPU, which makes life easier for everyone, both maintainers (you) and users.

  • Test it works on my computer.
  • Update wheel code so it can support the new --opencl-python-package option.
  • Have CI use that option.
  • Get CI tests passing with CPU.
  • Run CI tests both with CPU device and GPU device.
  • Get CI tests passing with GPU.
  • Review comments, if any.

@itamarst itamarst changed the title (WIP) Windows gpu builds, take 2 Windows GPU wheels Jun 9, 2020
@mirekphd
Copy link

mirekphd commented Aug 3, 2020

it will be possible to create a single wheel on Windows that work with both CPU and GPU devices.

I realize that Linux world is more diverse, but catboost python library devs manage to achieve this goal also for Linux. It saves users a lot of time... (At the cost of pinning to some Cuda build - ideally there should be versions built for Cuda 8, 9, 10, and 11).

@jameslamb
Copy link
Collaborator

Whenever you have time, can you please merge in master? Some changes have been made to our CI jobs to fix failures there. I apologize for the inconvenience.

@itamarst itamarst closed this Sep 22, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Also create a lightgbm-gpu release
4 participants