Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] fix learning-to-rank tests on Solaris #3534

Merged
merged 3 commits into from
Nov 8, 2020

Conversation

jameslamb
Copy link
Collaborator

This is a (hopefully temporary) workaround for #3513, as suggested in #3513 (comment). See that issue for details.

I think this is necessary for the 3.1.0 release (#3484 ), because without it the R package might fail CRAN's checks on Solaris.

I have tested on R Hub and confirmed this allows the R package to pass R CMD check on Solaris:

sh build-cran-package.sh
result <- rhub::check(
    path = "lightgbm_3.0.0.99.tar.gz"
    , email = "[email protected]"
    , check_args = c(
        "--as-cran"
    )
    , platform = c(
        "solaris-x86-patched"
        , "solaris-x86-patched-ods"
    )
    , env_vars = c(
        "R_COMPILE_AND_INSTALL_PACKAGES" = "always"
        , "_R_CHECK_FORCE_SUGGESTS_" = "true"
        , "_R_CHECK_CRAN_INCOMING_USE_ASPELL_" = "true"
    )
)

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

R-package/tests/testthat/test_learning_to_rank.R Outdated Show resolved Hide resolved
@jameslamb jameslamb merged commit 71a1a4f into microsoft:master Nov 8, 2020
@jameslamb jameslamb deleted the misc/fix-solaris-tests branch November 8, 2020 02:10
@StrikerRUS StrikerRUS mentioned this pull request Nov 21, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants