v3.3.0 release (fixes #4310) #4633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
requested review from
guolinke,
Laurae2,
shiyu1994 and
StrikerRUS
as code owners
|
/gha run r-configure |
jameslamb
commented
Sep 29, 2021
jameslamb
commented
Sep 29, 2021
| @@ -24,7 +25,8 @@ Authors@R: c( | |||
| person("Alberto", "Ferreira", role = c("ctb")), | |||
| person("Daniel", "Lemire", role = c("ctb")), | |||
| person("Victor", "Zverovich", role = c("cph")), | |||
| person("IBM Corporation", role = c("ctb")) | |||
| person("IBM Corporation", role = c("ctb")), | |||
| person("David", "Cortes", role = c("ctb")) | |||
There was a problem hiding this comment.
proposing adding @david-cortes to DESCRIPTION, thanks to their excellent recent contributions (https://github.com/microsoft/LightGBM/pulls?q=is%3Apr+author%3Adavid-cortes+is%3Aclosed)
|
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: success ✔️. |
|
/gha run r-solaris Workflow Solaris CRAN check has been triggered! 🚀 solaris-x86-patched: https://builder.r-hub.io/status/lightgbm_3.3.0.tar.gz-411d6e28def74dcaa37440e2cd1bf991 |
|
I'd like to point out that there's at least one blocker left for a potential CRAN release: #4598 |
@david-cortes we are not treating that as a blocker in releasing to CRAN. The code that issue describes has been in every previous LightGBM submission to CRAN and has not been flagged as problematic. It would be great to address it at some point but I don't favor delaying this release until that issue is picked up. |
But that's because it was only accessible from tests that were skipped. As those tests are now unskipped, they'd either have to be set to skipped again, or the issue addressed, otherwise it might randomly fail their tests (particularly solaris). |
This is not a correct statement. library(lightgbm)
data(agaricus.train, package = "lightgbm")
class(agaricus.train$data)
LightGBM/R-package/R/lgb.Dataset.R Lines 263 to 269 in a77260f |
StrikerRUS
approved these changes
Sep 29, 2021
|
@shiyu1994 are you ok with releasing the current state of this branch as 3.3.0? I'd like your approval before we merge this and start pushing to package managers. |
guolinke
approved these changes
Oct 5, 2021
|
Sure. I'm ok with this. |
shiyu1994
approved these changes
Oct 5, 2021
|
Thanks all! Before we merge... @StrikerRUS did you want #4637 to make it into 3.3.0? If so we'll need to merge latest |
|
Yeah, thanks! Let's merge recent commits. |
|
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: success ✔️. |
|
/gha run r-solaris Workflow Solaris CRAN check has been triggered! 🚀 Reports also have been sent to LightGBM public e-mail: https://yopmail.com?lightgbm_rhub_checks |
|
Thanks all! I'm running the R Solaris and If those tests pass, since we have 4 approvals I'll merge this PR and work through some of the other release items like setting a release / tag here on GitHub and submitting the R package to CRAN. |
|
There haven't been any updates on that R-hub issue, but going to try another build just in case they've fixed the issue but just haven't updated the issue yet. Maybe we'll get lucky. |
|
/gha run r-solaris Workflow Solaris CRAN check has been triggered! 🚀 Reports also have been sent to LightGBM public e-mail: https://yopmail.com?lightgbm_rhub_checks |
|
R Hub maintainers have just reported that the issue with Solaris has been fixed: r-hub/rhub#488 (comment) I'm going to wait until tonight to trigger a new build though, based on this comment from there:
I didn't realize that builds were queue-ing up during this outage. I want to wait until tonight to allow that service to catch up. Sorry for the delay! |
|
I just updated this to latest
I'm going to attempt the solaris and valgrind jobs again, hopefully R Hub's Solaris builds will be able to process our jobs successfully this time. If they pass and all other CI passes, I'll merge this and work on releasing to package managers! |
|
/gha run r-solaris Workflow Solaris CRAN check has been triggered! 🚀 solaris-x86-patched: https://builder.r-hub.io/status/lightgbm_3.3.0.tar.gz-c6a4d5a23f4d41c2bb5160b78fb5ea03 |
|
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: success ✔️. |
|
Ok, Solaris tests passed! Thanks for your patience, everyone. I'm going to merge this and start the work on the remaining checklist items. |
|
GitHub release for 3.3.0 has been published: https://github.com/microsoft/LightGBM/releases/tag/v3.3.0 and tag here's the Azure Pipelines build triggered by the new tag: https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=11089&view=results |
|
The jobs at Azure Pipelines completed successfully. Just submitted to CRAN!
I did the renaming we talked about in #4169 (comment) like so: wget \
https://github.com/microsoft/LightGBM/releases/download/v3.3.0/lightgbm-3.3.0-r-cran.tar.gz \
-O lightgbm_3.3.0.tar.gz@shiyu1994 please check your email. You should get an automated email from CRAN asking you to confirm this submission. |
|
Thank you @jameslamb. Done with that. |
|
Great, thank you! |
|
Source distribution of the R package is now available on CRAN. https://cran.r-project.org/web/packages/lightgbm/index.html We'll have to check https://cran.r-project.org/web/checks/check_results_lightgbm.html to see how the automated checks there go. Hoping they succeed!! |
Not sure whether these ASAN additional checks are counted for CRAN acceptance, but they are failing: and Links: |
|
@StrikerRUS Took a look at the error and it's not R specific. The issue is that you're using a C++ |
|
@david-cortes Thank you very much! |
shiyu1994
pushed a commit
that referenced
this pull request
Oct 20, 2021
* don't compare std::function to nullptr ref #4633 * Update dataset_loader.h
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing the 3.3.0 release.
Release checklist below was copied from #4169.
Release checklist:
configurefile of R-package:/gha run r-configure.development.modefromunreleasedtoreleasein pkgdown config file./gha run r-valgrind./gha run r-solaris.v*tag to triggerGitHubReleaseaction at Azure Pipelines.Draftto normal one.stabletag at GitHub.Necessary PRs and other Changes
I don't believe any additional PRs remain (we had been tracking this all along in #4310).
R-package/DESCRIPTION