Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] use wch1/r-debug image in Solaris tests #4765

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Conversation

jameslamb
Copy link
Collaborator

As a result of the changes #3946 , which introduce vignettes/ to the R package (part of #1944), building the R package with R CMD build will include installing the package, since it must be installed to create vignette outputs.

To make this work in the existing Solaris CI job, two changes are required:

  • pandoc must be available in the container used to build the package before submitting it to R Hub
  • {lightgbm}'s dependencies must be installed before running sh build-cran-package.sh.

This PR proposes both of those changes. It proposes the re-organization of test_r_package_solaris.sh just to make the diff of #3946 slightly smaller and easier to review.

Changing the image used in the Solaris job (to one that already has pandoc installed) needs to be done in a separate PR, since GitHub Actions configs for jobs triggered by comments are sourced from master (#4397 (comment)).

@@ -9,7 +9,7 @@ jobs:
name: solaris-cran
timeout-minutes: 120
runs-on: ubuntu-latest
container: rocker/r-base
container: wch1/r-debug
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noting this is the same image used in sanitizer jobs:

test-r-sanitizers:
name: r-sanitizers (ubuntu-latest, R-devel, ${{ matrix.compiler }} ASAN/UBSAN)
timeout-minutes: 60
runs-on: ubuntu-latest
container: wch1/r-debug

And those jobs are successfully building the package with vignettes.

https://github.com/microsoft/LightGBM/runs/4086356142?check_suite_focus=true

more evidence that this image has pandoc:

docker run --entrypoint="" -it wch1/r-debug pandoc --version

# pandoc 2.5
# Compiled with pandoc-types 1.17.5.4, texmath 0.11.2.2, skylighting 0.7.7
# Default user data directory: /root/.pandoc

@jameslamb jameslamb merged commit 1d0d746 into master Nov 3, 2021
@jameslamb jameslamb deleted the ci/solaris-image branch November 3, 2021 17:51
@jameslamb
Copy link
Collaborator Author

Solaris job is working with this change! #3946 (comment)

valgrind timed out (#3946 (comment)), tried triggering it again (#3946 (comment))

@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
13 tasks
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants