Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] use wch1/r-debug image in Solaris tests #4765

Merged
merged 3 commits into from
Nov 3, 2021
Merged

[ci] use wch1/r-debug image in Solaris tests #4765

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b762332
[ci] use wch1/r-debug image in Solaris tests
jameslamb Nov 3, 2021
5f33e72
no git in valgrind tests
jameslamb Nov 3, 2021
642fe37
Merge branch 'master' into ci/solaris-image
jameslamb Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .ci/test_r_package_solaris.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
#!/bin/bash

sh build-cran-package.sh || exit -1

apt-get install --no-install-recommends -y \
libcurl4-openssl-dev \
libxml2-dev \
libssl-dev

log_file="rhub_logs.txt"
Rscript -e "install.packages('rhub', dependencies = c('Depends', 'Imports', 'LinkingTo'), repos = 'https://cran.r-project.org', Ncpus = parallel::detectCores())" || exit -1

sh build-cran-package.sh || exit -1

log_file="rhub_logs.txt"
Rscript ./.ci/run_rhub_solaris_checks.R lightgbm_*.tar.gz $log_file || exit -1
3 changes: 1 addition & 2 deletions .github/workflows/r_solaris.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
name: solaris-cran
timeout-minutes: 120
runs-on: ubuntu-latest
container: rocker/r-base
container: wch1/r-debug
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noting this is the same image used in sanitizer jobs:

LightGBM/.github/workflows/r_package.yml

Lines 175 to 179 in da98f24

test-r-sanitizers:
name: r-sanitizers (ubuntu-latest, R-devel, ${{ matrix.compiler }} ASAN/UBSAN)
timeout-minutes: 60
runs-on: ubuntu-latest
container: wch1/r-debug

And those jobs are successfully building the package with vignettes.

https://github.com/microsoft/LightGBM/runs/4086356142?check_suite_focus=true

more evidence that this image has pandoc:

docker run --entrypoint="" -it wch1/r-debug pandoc --version

# pandoc 2.5
# Compiled with pandoc-types 1.17.5.4, texmath 0.11.2.2, skylighting 0.7.7
# Default user data directory: /root/.pandoc

env:
SECRETS_WORKFLOW: ${{ secrets.WORKFLOW }}
steps:
Expand All @@ -19,7 +19,6 @@ jobs:
apt-get update
apt-get install --no-install-recommends -y \
curl \
git \
jameslamb marked this conversation as resolved.
Show resolved Hide resolved
jq
- name: Checkout repository
uses: actions/[email protected]
Expand Down