Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor unnecessary try/catch #4057

Merged
merged 11 commits into from
Nov 19, 2024
Merged

Refactor unnecessary try/catch #4057

merged 11 commits into from
Nov 19, 2024

Commits on Nov 13, 2024

  1. Refactor unnecessary try/catch

    @Youssef1313
    Youssef1313 authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    0007764 View commit details
    Browse the repository at this point in the history

  2. Remove one more unnecessary try/catch

    @Youssef1313
    Youssef1313 authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c3819e2 View commit details
    Browse the repository at this point in the history

  3. Fix formatting

    @Youssef1313
    Youssef1313 authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    444a938 View commit details
    Browse the repository at this point in the history

  4. Fix test failures

    @Youssef1313
    Youssef1313 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ce7848d View commit details
    Browse the repository at this point in the history

  5. Refactor a bit more

    @Youssef1313
    Youssef1313 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    75db0fe View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Merge branch 'main' into dev/ygerges/unnecessary-try-catch

    @Evangelink
    Evangelink authored Nov 15, 2024
    Configuration menu
    Copy the full SHA
    6ebcb5f View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. Adjust back again so that the exception is thrown by callers

    @Youssef1313
    Youssef1313 committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    838302b View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Adjust the logic and add test

    @Youssef1313
    Youssef1313 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    ac44c91 View commit details
    Browse the repository at this point in the history

  2. Assert the exception message

    @Youssef1313
    Youssef1313 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    04db4fd View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Address review comments

    @Youssef1313
    Youssef1313 committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3f45364 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into dev/ygerges/unnecessary-try-catch

    @Evangelink
    Evangelink authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    bcddb36 View commit details
    Browse the repository at this point in the history