Make bitcast work for tensors of pointers #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
among currently open, this is probably the most interesting PR for me in terms of understanding some fundamental ideas @nhat-nguyen could you please take a look when you have a chance |
parsifal-47
force-pushed
the
fix-compare
branch
from
216602c to
eaaf7c5
Compare
|
@haishanzzzz and his team at Meta has an unpublished PR that also handles bitcast, so let's wait until he's back so we can coordinate how to handle this. |
|
@haishanzzzz are you back? could you please take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could be missing some high-level ideas about Triton Structured, here is my reasoning:
When bitcasting tensor<ptr> -> tensor<ptr<something_else>> arith::bitcast does not work and all memref/tensor casts. However no manipulations to the data are needed, this is a transformation like casting between different pointer types. I introduced ptr_cast on tts level which becomes unrealized conversion once all types for pointers are settled. This change fixes all comparison tests that require pointer casting at store. Let me know what you think!