Support reading a object type setting with simple value types

[sandy081]

With #84756, I have added a new setting extensions.allowed that will have a list of extensions that will be allowed. The value of this setting is of type object and the value of each key is true | false | "stable" | array of string versions. At present user can view the value of this setting only from settings.json file. If it is made a policy setting then the setting editor does not support showing the value of this setting.

Hence, I added support for showing the value of such setting type where the value is an object with simple value types. User can now view the value from the settings editor and to update we show the link to edit in settings.json file as below

[rzhao271]

1. When I edit the setting in settings.json, accept the default value '*', and go back to the Settings editor, I get an error message saying "Setting has an invalid type".
2. Using a link instead of a button for "Edit in settings.json" LGTM because clicking on it changes the view. Could you add some padding between the table and the link so that the link doesn't look like it's one of the table entries? Also, NVDA states the element is a button instead of a link, even though it looks like a link. Could the element type be changed to a link?

[sandy081]

Thanks for the feedback.

When I edit the setting in settings.json, accept the default value '*', and go back to the Settings editor, I get an error message saying "Setting has an invalid type".

Good catch. It is currently a limitation because of the policy setting. Please check this note here:

vscode/src/vs/workbench/contrib/extensions/browser/extensions.contribution.ts

Line 275 in 8c67f12

// Note: Type is set only to object because to support policies generation during build time, where single type is expected.

Also, NVDA states the element is a button instead of a link, even though it looks like a link. Could the element type be changed to a link?

I took the same link element from complex setting renderer here:

vscode/src/vs/workbench/contrib/preferences/browser/settingsTree.ts

Lines 1143 to 1145 in 8c67f12

	const openSettingsButton = DOM.append(common.controlElement, $('a.edit-in-settings-button'));
	openSettingsButton.classList.add(AbstractSettingRenderer.CONTROL_CLASS);
	openSettingsButton.role = 'button';

Do you want to change both then?

[rzhao271]

I'll take another look at the complex link/button during debt week or housekeeping.
LGTM!