Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have run-docker-teardown respect services variable #4884

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

evankanderson
Copy link
Member

Summary

I wanted to run make run-docker services=minder to only reload minder without tearing down keycloak, openfga, or the postgres DB. Unfortunately, run-docker depends on run-docker-teardown, which didn't qualify the services being shut down. This fixes that, so you can iterate with the prevous command.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

I've been using this to speed up my manual test loop.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner November 5, 2024 18:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11690089778

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.769%

Totals Coverage Status
Change from base Build 11689795417: 0.0%
Covered Lines: 15534
Relevant Lines: 28363

💛 - Coveralls

@evankanderson evankanderson changed the title Have run-docker-teardown respect services Have run-docker-teardown respect services variable Nov 5, 2024
@evankanderson evankanderson merged commit 7e6460a into mindersec:main Nov 5, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants