fix: adding an environment value to enable the ignoring of the name, accessKey and secretKey in configSecret.

[drew-viles]

Description

In version 6.0.4 the inclusion of this check broke the ability to pass the existingSecret value because the default values provided in the values.yaml file caused the error to trigger. It seems incorrect to have to provide the following to make it work:

  configSecret:
    name: ""
    accessKey: ""
    secretKey: ""
    existingSecret: true

Now we can presume that in dev the values will be provided in line as per the values file and in any other situation, they are provided via an existing secret.

There may be a better way than this, but I've rolled this out and it's fixed the problem I had when upgrading to 6.0.4.

Type of Change

• Bug fix 🐛
• New feature 🚀
• Breaking change 🚨
• Documentation update 📖
• Refactor 🔨
• Other (please describe) ⬇️

Screenshots (if applicable e.g before/after)

Checklist

• I have tested these changes
• I have updated relevant documentation (if applicable)
• I have added necessary unit tests (if applicable)

Test Steps

1. Roll out Minio chart with the existing secret as described above. Watch it fail.
2. Roll it out with this change with or without .Values.tenant.environment set as per the conditional, watch it succeed.

Additional Notes / Context

[drew-viles]

Would you be able to take a look at this please @ramondeklein?

I'm seeing a few people hit by this and whilst we can explicitly blank out accessKey and secretKey in the chart, this feels like an anti-pattern in that it's opt out instead of opt in.

[ramondeklein]

I rather not introduce more variables. I have submitted #2412. Could you check if that would fix your issues?

[drew-viles]

That's reasonable, let me check the other one you've linked to see if it resolves it