allow users know when to enable and disable performance insights #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sablumiah
reviewed
Apr 8, 2024
variables.tf
Outdated
| @@ -97,7 +97,7 @@ variable "ca_cert_identifier" { | |||
|
|
|||
| variable "performance_insights_enabled" { | |||
| type = bool | |||
| description = "Enable performance insights for RDS?" | |||
| description = "Enable performance insights for RDS? This is disabled by default. However a user can enable it if certain insights are needed from the Database. However, the user should ensure it is disabled once the desired outcome is achieved." | |||
There was a problem hiding this comment.
Maybe remove the second however and change to "The user should also ensure..."
There was a problem hiding this comment.
Thanks Sablu.
variables.tf
Outdated
| @@ -97,7 +97,7 @@ variable "ca_cert_identifier" { | |||
|
|
|||
| variable "performance_insights_enabled" { | |||
| type = bool | |||
| description = "Enable performance insights for RDS?" | |||
| description = "Enable performance insights for RDS? This is disabled by default. However a user can enable it if certain insights are needed from the Database. However, the user should ensure it is disabled once the desired outcome is achieved." | |||
There was a problem hiding this comment.
"Enable performance insights for RDS? Note: the user should ensure insights are disabled once the desired outcome is achieved."
I don't think you need to explicitly mention the other things as that's implicit from reading the code
There was a problem hiding this comment.
Thanks Jazz. Updated it.
jaskaransarkaria
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.