-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow users know when to enable and disable performance insights #169
Changes from 2 commits
4babe51
17082bb
386109e
4b49f1b
91d4dcf
de3c1cf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -97,7 +97,7 @@ variable "ca_cert_identifier" { | |
|
||
variable "performance_insights_enabled" { | ||
type = bool | ||
description = "Enable performance insights for RDS?" | ||
description = "Enable performance insights for RDS? This is disabled by default. However a user can enable it if certain insights are needed from the Database. However, the user should ensure it is disabled once the desired outcome is achieved." | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Enable performance insights for RDS? Note: the user should ensure insights are disabled once the desired outcome is achieved." I don't think you need to explicitly mention the other things as that's implicit from reading the code There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks Jazz. Updated it. |
||
default = false | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe remove the second however and change to "The user should also ensure..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sablu.