Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to readme for first time creation of local environment #1786

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Minor fixes to readme for first time creation of local environment #1786

merged 3 commits into from
Jan 6, 2025

Conversation

jamesrwarren
Copy link
Contributor

@jamesrwarren jamesrwarren commented Jan 6, 2025 •
edited
Loading

Purpose

Tweaks to readme and composer file for first time local environment creation.

Approach

Couple of changes:

  • Removed some lingering code in docker compose files from the synch lambda that was removed in a previous PR
  • Updated the readme file

Learning

NA

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/ADR/tech debt doc) where relevant
  • I have added tests to prove my work
  • The product team have approved these changes
  • I have checked my work for potential security issues and refered to the OWASP top 10

Frontend

  • I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
  • There are no deprecated CSS classes noted in the profiler
  • Translations are used and the profiler doesn't identify any missing
  • Any links or buttons added are screen reader friendly and contextually complete
  • If adding GA events, I have updated or checked the existing category or label values

@jamesrwarren jamesrwarren changed the title small fixes to readme for first creation of app Minor fixes to readme for first time creation of local environment Jan 6, 2025
@jamesrwarren jamesrwarren marked this pull request as ready for review January 6, 2025 13:38
@jamesrwarren jamesrwarren requested a review from a team as a code owner January 6, 2025 13:38
jogilder
jogilder approved these changes Jan 6, 2025
View reviewed changes
Copy link

@jogilder jogilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesrwarren jamesrwarren merged commit f38c770 into main Jan 6, 2025
37 checks passed
@jamesrwarren jamesrwarren deleted the fix_local branch January 6, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raffers Raffers Raffers approved these changes

@jogilder jogilder jogilder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesrwarren @jogilder @Raffers