Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to readme for first time creation of local environment #1786

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Minor fixes to readme for first time creation of local environment #1786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c082856
small fixes to readme for first creation of app
jamesrwarren Jan 6, 2025
63dafad
Merge branch 'main' into fix_local
jamesrwarren Jan 6, 2025
e9f18ee
Merge branch 'main' into fix_local
jamesrwarren Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,13 @@ If developing the app then ensure you have [pre-commit](https://pre-commit.com/)

#### M1 macOS Monterey ≥ 12.2 | Intel macOS Monterey ≥ 12.3 Docker settings

* `Docker preferences -> Experimental Features -> tick 'Use the new Virtualization framework'`
* `Docker preferences -> Experimental Features -> tick 'Enable VirtioFS accelerated directory sharing'`
* `Docker settings -> General -> make sure 'Use the new Virtualization framework' is ticked`
* `Docker settings -> General -> tick 'VirtioFS' for file sharing`
* `Docker settings -> General -> untick 'Use Rosetta'`

Once both boxes are checked click `Apply & Restart` then run the `Make` command `make up-app-build`
Also in `Docker settings -> Resources`, make sure that you have at least 10gb of memory allocated or you may get performance issues.

Once both boxes are checked click `Apply & Restart` then continue to follow the instructions below.

## Installation

Expand Down
4 changes: 0 additions & 4 deletions docker-compose.override.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,6 @@ services:
volumes:
- ./htmltopdf/app.py:/app.py

synchronisation:
volumes:
- ./lambdas/functions/synchronisation/.aws-lambda-rie:/aws-lambda

mock-notify-api:
volumes:
- ./client/app/govuk-notifications.yaml:/tmp/govuk-notifications.yaml
Expand Down
18 changes: 0 additions & 18 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,9 +201,6 @@ services:
- DEFAULT_REGION=eu-west-1
- USE_SINGLE_REGION=1
- DEBUG=1
- LAMBDA_EXECUTOR=docker
- LAMBDA_REMOVE_CONTAINERS="true"
- LAMBDA_FORWARD_URL=http://synchronisation:8080

wait-for-it:
build: ./wait-for-it
Expand Down Expand Up @@ -249,21 +246,6 @@ services:
- 0.0.0.0
- --dynamic

synchronisation:
container_name: opg-synchronisation-lambda
build:
context: ./lambdas/functions/synchronisation
ports:
- 2080:8080
environment:
AWS_REGION: eu-west-1
AWS_ACCESS_KEY_ID: localstack
AWS_SECRET_ACCESS_KEY: localstack
DIGIDEPS_SYNC_ENDPOINT: https://frontend
SECRETS_PREFIX: local
LOCALSTACK_ENDPOINT: http://localstack:4566
entrypoint: /aws-lambda/aws-lambda-rie /var/task/main

composer:
image: composer:2.5.7
command: ["install"]
Expand Down
Loading