Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3106 Implement One Login callback handler on service-front #2445

Merged
merged 17 commits into from
Dec 11, 2023

Conversation

MishNajam
Copy link
Contributor

@MishNajam MishNajam commented Nov 22, 2023

Purpose

Handles when an error is returned from One Login. This will either:

  • on an access denied or temporarily unavailable error return the user to the login page with an error message
  • on any other error send the user to the generic error page

Other changes:

  • Stores the redirect_uri in the auth session
  • Adds an override to the redirect method to return the page in Welsh if it is set
  • Replaced deprecated method assertObjectHasAttribute with assertObjectHasProperty

Fixes UML-3106

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@MishNajam MishNajam requested a review from a team as a code owner November 22, 2023 17:37
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #2445 (f45d7f9) into main (1327c6f) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2445      +/-   ##
============================================
+ Coverage     91.88%   91.94%   +0.06%     
+ Complexity     1467     1466       -1     
============================================
  Files           279      278       -1     
  Lines          6653     6653              
============================================
+ Hits           6113     6117       +4     
+ Misses          523      519       -4     
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 88.81% <ø> (ø)
use-an-lpa-api 96.80% <ø> (+0.18%) ⬆️
use-an-lpa-front 89.11% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...vice-front/app/src/Actor/src/Form/OneLoginForm.php 100.00% <ø> (ø)
...rc/Common/src/Service/OneLogin/OneLoginService.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@MishNajam MishNajam force-pushed the UML-3106-one-login-service-front-handle-return branch from 2047714 to 25900b4 Compare December 7, 2023 17:10
@MishNajam MishNajam force-pushed the UML-3106-one-login-service-front-handle-return branch from 712a221 to aa6772b Compare December 7, 2023 17:33
@MishNajam MishNajam force-pushed the UML-3106-one-login-service-front-handle-return branch from f16a444 to c1b0a32 Compare December 8, 2023 16:10
@MishNajam MishNajam merged commit 66b939c into main Dec 11, 2023
31 checks passed
@MishNajam MishNajam deleted the UML-3106-one-login-service-front-handle-return branch December 11, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants