-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UML-3106 Implement One Login callback handler on service-front #2445
Merged
MishNajam
merged 17 commits into
main
from
UML-3106-one-login-service-front-handle-return
Dec 11, 2023
Merged
UML-3106 Implement One Login callback handler on service-front #2445
MishNajam
merged 17 commits into
main
from
UML-3106-one-login-service-front-handle-return
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2445 +/- ##
============================================
+ Coverage 91.88% 91.94% +0.06%
+ Complexity 1467 1466 -1
============================================
Files 279 278 -1
Lines 6653 6653
============================================
+ Hits 6113 6117 +4
+ Misses 523 519 -4
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
MishNajam
commented
Nov 28, 2023
service-front/app/src/Common/src/Service/OneLogin/OneLoginService.php
Outdated
Show resolved
Hide resolved
MishNajam
commented
Dec 6, 2023
MishNajam
commented
Dec 6, 2023
MishNajam
commented
Dec 6, 2023
service-front/app/src/Actor/src/Handler/OneLoginCallbackHandler.php
Outdated
Show resolved
Hide resolved
MishNajam
commented
Dec 6, 2023
MishNajam
commented
Dec 6, 2023
service-front/app/test/CommonTest/Service/OneLogin/OneLoginServiceTest.php
Outdated
Show resolved
Hide resolved
MishNajam
force-pushed
the
UML-3106-one-login-service-front-handle-return
branch
from
December 7, 2023 17:10
2047714
to
25900b4
Compare
MishNajam
force-pushed
the
UML-3106-one-login-service-front-handle-return
branch
from
December 7, 2023 17:33
712a221
to
aa6772b
Compare
MishNajam
force-pushed
the
UML-3106-one-login-service-front-handle-return
branch
from
December 8, 2023 16:10
f16a444
to
c1b0a32
Compare
cooperaj
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Handles when an error is returned from One Login. This will either:
Other changes:
Fixes UML-3106
Checklist