Uml 3394 combined lpa manager

[cooperaj]

Purpose

Implement a combined LPA manager capable of retrieving LPA data from Sirius and Data Store.

Fixes UML-3394

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service

Checklist

• I have performed a self-review of my own code
• I have added relevant logging with appropriate levels to my code
• New event_codes have been documented on the wiki page
• I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
• I have added tests to prove my work
• I have added welsh translation tags and updated translation files
• I have run an accessibility tool on any pages I have made changes to and fixed any issues found
• I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
• The product team have tested these changes

[codecov]

Codecov Report

Attention: Patch coverage is 76.82119% with 105 lines in your changes missing coverage. Please review.

Project coverage is 90.52%. Comparing base (818972a) to head (1bef6a5).

Files with missing lines	Patch %	Lines
...Service/Lpa/ResolveActor/LpaStoreHasActorTrait.php	0.00%	21 Missing ⚠️
...pp/src/Service/Lpa/Combined/FilterActiveActors.php	0.00%	15 Missing ⚠️
...c/App/src/Service/Lpa/Combined/ResolveLpaTypes.php	0.00%	13 Missing ⚠️
...on/src/Service/Lpa/Factory/PersonDataFormatter.php	0.00%	11 Missing ⚠️
...app/src/App/src/Service/Lpa/CombinedLpaManager.php	89.53%	9 Missing ⚠️
...p/src/Entity/Casters/CastToWhenTheLpaCanBeUsed.php	0.00%	7 Missing ⚠️
.../app/src/App/src/Service/JWT/JWSBuilderFactory.php	0.00%	5 Missing ⚠️
...p/src/App/src/DataAccess/ApiGateway/SiriusLpas.php	0.00%	4 Missing ⚠️
service-front/app/src/Common/src/Entity/Person.php	75.00%	4 Missing ⚠️
...app/src/App/src/Enum/HowAttorneysMakeDecisions.php	62.50%	3 Missing ⚠️
... and 8 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2782      +/-   ##
============================================
- Coverage     91.95%   90.52%   -1.43%     
+ Complexity     1781     1747      -34     
============================================
  Files           390      359      -31     
  Lines          8275     8172     -103     
============================================
- Hits           7609     7398     -211     
- Misses          649      757     +108     
  Partials         17       17              

Flag	Coverage Δ
use-an-lpa-admin	78.85% <ø> (ø)
use-an-lpa-api	94.64% <77.46%> (-2.67%)	⬇️
use-an-lpa-front	89.77% <73.13%> (-0.92%)	⬇️

Files with missing lines	Coverage Δ
...rc/App/src/DataAccess/ApiGateway/DataStoreLpas.php	98.73% <100.00%> (-1.27%)	⬇️
...src/DataAccess/ApiGateway/DataStoreLpasFactory.php	100.00% <100.00%> (ø)
...src/DataAccess/ApiGateway/RequestSignerFactory.php	100.00% <100.00%> (ø)
...src/App/src/DataAccess/Repository/Response/Lpa.php	100.00% <100.00%> (ø)
...App/src/Entity/Casters/ExtractAddressFieldFrom.php	100.00% <100.00%> (ø)
...e-api/app/src/App/src/Entity/LpaStore/LpaStore.php	92.50% <100.00%> (+1.59%)	⬆️
...p/src/App/src/Entity/LpaStore/LpaStoreAttorney.php	100.00% <100.00%> (ø)
.../app/src/App/src/Entity/LpaStore/LpaStoreDonor.php	100.00% <100.00%> (ø)
...p/src/Entity/LpaStore/LpaStoreTrustCorporation.php	100.00% <100.00%> (ø)
service-api/app/src/App/src/Entity/Person.php	100.00% <100.00%> (ø)
... and 38 more

... and 3 files with indirect coverage changes