Uml 3394 combined lpa manager

[cooperaj]

Purpose

Implement a combined LPA manager capable of retrieving LPA data from Sirius and Data Store.

Fixes UML-3394

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service

Checklist

• I have performed a self-review of my own code
• I have added relevant logging with appropriate levels to my code
• New event_codes have been documented on the wiki page
• I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
• I have added tests to prove my work
• I have added welsh translation tags and updated translation files
• I have run an accessibility tool on any pages I have made changes to and fixed any issues found
• I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
• The product team have tested these changes

[codecov]

Codecov Report

Attention: Patch coverage is 96.57388% with 16 lines in your changes missing coverage. Please review.

Project coverage is 91.77%. Comparing base (38c7bd6) to head (461ed67).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../app/src/App/src/Service/JWT/JWSBuilderFactory.php	0.00%	5 Missing ⚠️
...p/src/App/src/DataAccess/ApiGateway/SiriusLpas.php	0.00%	4 Missing ⚠️
...app/src/App/src/Service/Lpa/CombinedLpaManager.php	96.42%	3 Missing ⚠️
.../src/App/src/DataAccess/ApiGateway/GenerateJWT.php	0.00%	1 Missing ⚠️
...vice-api/app/src/App/src/Service/Lpa/SiriusLpa.php	0.00%	1 Missing ⚠️
...nt/app/src/Common/src/Service/Lpa/ParseLpaData.php	92.30%	1 Missing ⚠️
...ront/app/src/Common/src/View/Twig/LpaExtension.php	94.73%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2782      +/-   ##
============================================
- Coverage     91.94%   91.77%   -0.17%     
+ Complexity     1779     1747      -32     
============================================
  Files           391      360      -31     
  Lines          8269     8172      -97     
============================================
- Hits           7603     7500     -103     
- Misses          649      655       +6     
  Partials         17       17              

Flag	Coverage Δ
use-an-lpa-admin	78.85% <ø> (ø)
use-an-lpa-api	97.11% <96.41%> (-0.21%)	⬇️
use-an-lpa-front	90.21% <97.36%> (-0.47%)	⬇️

Files with missing lines	Coverage Δ
...rc/App/src/DataAccess/ApiGateway/DataStoreLpas.php	98.73% <100.00%> (-1.27%)	⬇️
...src/DataAccess/ApiGateway/DataStoreLpasFactory.php	100.00% <100.00%> (ø)
...src/DataAccess/ApiGateway/RequestSignerFactory.php	100.00% <100.00%> (ø)
...src/App/src/DataAccess/Repository/Response/Lpa.php	100.00% <100.00%> (ø)
...p/src/App/src/Entity/Casters/CastToCaseSubtype.php	100.00% <100.00%> (ø)
...c/Entity/Casters/CastToLifeSustainingTreatment.php	100.00% <100.00%> (ø)
...p/src/Entity/Casters/CastToWhenTheLpaCanBeUsed.php	100.00% <100.00%> (ø)
...App/src/Entity/Casters/ExtractAddressFieldFrom.php	100.00% <100.00%> (ø)
service-api/app/src/App/src/Entity/Lpa.php	100.00% <100.00%> (ø)
...e-api/app/src/App/src/Entity/LpaStore/LpaStore.php	92.50% <100.00%> (+1.59%)	⬆️
... and 38 more

... and 1 file with indirect coverage changes

[nickdavis2001]

🏆