Code

Uml 3394 combined lpa manager#2782

Code

Merged

cooperaj merged 100 commits intomainministryofjustice/opg-use-an-lpa:mainfrom UML-3394-combined-lpa-managerministryofjustice/opg-use-an-lpa:UML-3394-combined-lpa-managerCopy head branch name to clipboardJan 20, 2025

+5,791-6,918

Commits

Commits on Jan 17, 2025

• Move to a feature flagged factory for lpa manager creation

  cooperaj

  committed
  708f31d

  Copy full SHA for 708f31d

• Move to using the lpa service interface in preparation for v2 strategy.

  cooperaj

  committed
  5c80c28

  Copy full SHA for 5c80c28

• Update typing information

  cooperaj

  committed
  1b9e4ee

  Copy full SHA for 1b9e4ee

• Add authentication to v2 lpas endpoint

  cooperaj

  committed
  a6e3e2c

  Copy full SHA for a6e3e2c

• Incorrect container usage

  cooperaj

  committed
  ec2cb6f

  Copy full SHA for ec2cb6f

• Use own JWS builder as one in library is not usable how we need.

  cooperaj

  committed
  fb92e71

  Copy full SHA for fb92e71

• Use correct secret field name

  cooperaj

  committed
  ddc2549

  Copy full SHA for ddc2549

• Add datastorelpas to configprovider

  cooperaj

  committed
  099914e

  Copy full SHA for 099914e

• Ensure necessary parameter is added to request signer.

  Show description for 97be503
  cooperaj

  committed
  97be503

  Copy full SHA for 97be503

• Add work in progress combined lpa manager and point v2 handler at it.

  cooperaj

  committed
  230fc39

  Copy full SHA for 230fc39

• Managed to add this back in during conflict resolving.

  cooperaj

  committed
  df18b2e

  Copy full SHA for df18b2e

• Rename LpaManagerInterface method as it was a bit clumsy

  cooperaj

  committed
  c475071

  Copy full SHA for c475071

• Seed LpaStore lpa

  cooperaj

  committed
  40dc984

  Copy full SHA for 40dc984

• Use LpaDataFormatter for LpaStore lpas

  cooperaj

  committed
  fda86dc

  Copy full SHA for fda86dc

• Work to further combine lpa types

  cooperaj

  committed
  7293c1b

  Copy full SHA for 7293c1b

• Create openapi documentation for lpas endpoint.

  cooperaj

  committed
  74fb7b1

  Copy full SHA for 74fb7b1

• To make the api work with the Swagger editor cors headers need setting appropriately.

  Show description for 8a14fdd
  cooperaj

  committed
  8a14fdd

  Copy full SHA for 8a14fdd

• Composer run script update

  cooperaj

  committed
  cedb861

  Copy full SHA for cedb861

• Add spaties cloneable so we can manipulate our readonly objects (bring on PHP 8.4)

  cooperaj

  committed
  e7bf4d5

  Copy full SHA for e7bf4d5

• Add WhenLpaCanBeUsed field to the openapi doc

  cooperaj

  committed
  9c81c42

  Copy full SHA for 9c81c42

• Update example openapi lpa

  cooperaj

  committed
  9fce63b

  Copy full SHA for 9fce63b

• Tweaking how frontend templated deal with cast type and other enums

  cooperaj

  committed
  788fb97

  Copy full SHA for 788fb97

• Move enum value deciphering to the casters rather than being in the enums themselves.

  cooperaj

  committed
  dddb888

  Copy full SHA for dddb888

• Remove all concept of differing LPA types on the frontend.

  cooperaj

  committed
  d0e5cc6

  Copy full SHA for d0e5cc6

• Define interfaces for the frontend entity functions that we use.

  Show description for 6cb4739
  cooperaj

  committed
  6cb4739

  Copy full SHA for 6cb4739

• Clean up class variable usage

  cooperaj

  committed
  b69c3ce

  Copy full SHA for b69c3ce

• Stop using address arrays if we have a Person on template output

  cooperaj

  committed
  6bf1c2e

  Copy full SHA for 6bf1c2e

• Handler tidy up

  cooperaj

  committed
  60bae18

  Copy full SHA for 60bae18

• v2 handler urls is nice and all but actually pretty complex to implement

  cooperaj

  committed
  88ce2a3

  Copy full SHA for 88ce2a3

• Docblock updates

  cooperaj

  committed
  6c9da3d

  Copy full SHA for 6c9da3d

• Make ViewerCodeService Uid source agnostic

  cooperaj

  committed
  fe92de3

  Copy full SHA for fe92de3

• Not really possible to break the rest of this down.

  Show description for 4f6d07e
  cooperaj

  committed
  4f6d07e

  Copy full SHA for 4f6d07e

• Don't need a pipeline setup for a route that doesn't exist.

  cooperaj

  committed
  535d35e

  Copy full SHA for 535d35e

• First test fixes

  cooperaj

  committed
  d0a4029

  Copy full SHA for d0a4029

• fix test

  

  nickdavis2001

  authored and

  cooperaj

  committed
  d57dd7e

  Copy full SHA for d57dd7e

• fix test

  

  nickdavis2001

  authored and

  cooperaj

  committed
  ed55069

  Copy full SHA for ed55069

• fix test

  

  nickdavis2001

  authored and

  cooperaj

  committed
  7f2ba7c

  Copy full SHA for 7f2ba7c

• Fix RequestSignerFactoryTest.php test

  cooperaj

  committed
  db81293

  Copy full SHA for db81293

• fix test

  

  nickdavis2001

  authored and

  cooperaj

  committed
  495f4f4

  Copy full SHA for 495f4f4

• fix tests

  

  nickdavis2001

  authored and

  cooperaj

  committed
  8de701f

  Copy full SHA for 8de701f

• fix test

  

  nickdavis2001

  authored and

  cooperaj

  committed
  31df338

  Copy full SHA for 31df338

• Fixes to Casters and entities

  cooperaj

  committed
  d802965

  Copy full SHA for d802965

• Fixes to Casters and entities

  cooperaj

  committed
  e44545a

  Copy full SHA for e44545a

• Fixup address extraction in caster for Sirius Lpas

  cooperaj

  committed
  bc7eeee

  Copy full SHA for bc7eeee

• Serialisation test for lpa store

  cooperaj

  committed
  47d0f19

  Copy full SHA for 47d0f19

• fix tests

  

  nickdavis2001

  authored and

  cooperaj

  committed
  d8ee685

  Copy full SHA for d8ee685

• Serialisation test for Sirius lpas

  cooperaj

  committed
  3272f12

  Copy full SHA for 3272f12

• fix tests

  

  nickdavis2001

  authored and

  cooperaj

  committed
  4d382e8

  Copy full SHA for 4d382e8

• Serialisation test for Sirius into combined format

  cooperaj

  committed
  17f0d90

  Copy full SHA for 17f0d90

• fix test

  

  nickdavis2001

  authored and

  cooperaj

  committed
  ed0c39e

  Copy full SHA for ed0c39e

• fix tests

  

  nickdavis2001

  authored and

  cooperaj

  committed
  ea9cb89

  Copy full SHA for ea9cb89

• fix test

  

  nickdavis2001

  authored and

  cooperaj

  committed
  da272b8

  Copy full SHA for da272b8

• fix some of test

  

  nickdavis2001

  authored and

  cooperaj

  committed
  420f68e

  Copy full SHA for 420f68e

• Fixup FindActorInLpaTest by making Sirius objects a little more robust

  cooperaj

  committed
  614528d

  Copy full SHA for 614528d

• Final set of unit test fixes (before we start codecoverage work)

  cooperaj

  committed
  72909f3

  Copy full SHA for 72909f3

• Tidy up entity handling around enum casting and life sustaining treatment

  cooperaj

  committed
  dce1478

  Copy full SHA for dce1478

• combined manager test

  

  nickdavis2001

  authored and

  cooperaj

  committed
  e72ad9f

  Copy full SHA for e72ad9f

• UML-3750 fixed frontend unit tests

  

  allenannom

  authored and

  cooperaj

  committed
  f875d1b

  Copy full SHA for f875d1b

• fix up mocks

  

  nickdavis2001

  authored and

  cooperaj

  committed
  023a2ed

  Copy full SHA for 023a2ed

• Start of work on CombinedLpaManagerTest

  cooperaj

  committed
  bfa5ef0

  Copy full SHA for bfa5ef0

• fix test broken by merge of main into branch

  

  nickdavis2001

  authored and

  cooperaj

  committed
  312b107

  Copy full SHA for 312b107

• WIP tests

  

  nickdavis2001

  authored and

  cooperaj

  committed
  0121a57

  Copy full SHA for 0121a57

• WIP broken, working on test

  

  nickdavis2001

  authored and

  cooperaj

  committed
  2fc45a1

  Copy full SHA for 2fc45a1

• UML-3394 fix ui

  

  allenannom

  authored and

  cooperaj

  committed
  76b5220

  Copy full SHA for 76b5220

• UML-3394 updated frontend tests - fixed behat tests with feature flag enabled

  

  allenannom

  authored and

  cooperaj

  committed
  9444fe7

  Copy full SHA for 9444fe7

• Improvements to CombinedLpaManagerTest coverage

  cooperaj

  committed
  958232f

  Copy full SHA for 958232f

• UML-3394 updated frontend tests - fixed behat tests

  

  allenannom

  authored and

  cooperaj

  committed
  30245b5

  Copy full SHA for 30245b5

• Add test for user token fetch of Sirius LPA

  cooperaj

  committed
  5e27172

  Copy full SHA for 5e27172

• Final coverage fixes for CombinedLpaManager

  cooperaj

  committed
  5f45f37

  Copy full SHA for 5f45f37

• Composer updates

  cooperaj

  committed
  ec9b217

  Copy full SHA for ec9b217

• UML-3394 updated front-end tests and improved codecov

  

  allenannom

  authored and

  cooperaj

  committed
  9996a23

  Copy full SHA for 9996a23

• UML-3394 updated api tests and improved codecov

  

  allenannom

  authored and

  cooperaj

  committed
  2898be6

  Copy full SHA for 2898be6

• UML-3394 added ResolveLpaTypeTest.php

  

  allenannom

  authored and

  cooperaj

  committed
  c575951

  Copy full SHA for c575951

• UML-3619 wip

  

  allenannom

  authored and

  cooperaj

  committed
  6ef41db

  Copy full SHA for 6ef41db

• UML-3619 Convert incoming LPAs to combined format (repository layer)

  

  allenannom

  authored and

  cooperaj

  committed
  4815110

  Copy full SHA for 4815110

• UML-3394 updated CastToWhenTheLpaCanBeUsedTest.php

  

  allenannom

  authored and

  cooperaj

  committed
  864f781

  Copy full SHA for 864f781

• Move to a feature flagged factory for lpa manager creation

  cooperaj

  committed
  988d12f

  Copy full SHA for 988d12f

• Move to using the lpa service interface in preparation for v2 strategy.

  cooperaj

  committed
  ca8bfb5

  Copy full SHA for ca8bfb5

• Add authentication to v2 lpas endpoint

  cooperaj

  committed
  cf29675

  Copy full SHA for cf29675

• Managed to add this back in during conflict resolving.

  cooperaj

  committed
  b9a105a

  Copy full SHA for b9a105a

• Clean up class variable usage

  cooperaj

  committed
  5a934b7

  Copy full SHA for 5a934b7

• Not really possible to break the rest of this down.

  Show description for 344c94d
  cooperaj

  committed
  344c94d

  Copy full SHA for 344c94d

• Don't need a pipeline setup for a route that doesn't exist.

  cooperaj

  committed
  fcdce84

  Copy full SHA for fcdce84

• Fixes to Casters and entities

  cooperaj

  committed
  5524f0a

  Copy full SHA for 5524f0a

• Final set of unit test fixes (before we start codecoverage work)

  cooperaj

  committed
  dcc0674

  Copy full SHA for dcc0674

• fix test broken by merge in of main

  

  nickdavis2001

  authored and

  cooperaj

  committed
  f57e951

  Copy full SHA for f57e951

• Use mock logger in place of Monolog instance

  cooperaj

  committed
  b19b2b1

  Copy full SHA for b19b2b1

• UML-3394 updated frontend tests - fixed behat tests with feature flag enabled

  

  allenannom

  authored and

  cooperaj

  committed
  63e45ef

  Copy full SHA for 63e45ef

• Fix up some merge issues.

  cooperaj

  committed
  aaaf483

  Copy full SHA for aaaf483

• Fix FindActorInLpa tests

  cooperaj

  committed
  b85c214

  Copy full SHA for b85c214

• Tidy up route.php imports

  cooperaj

  committed
  02a11fc

  Copy full SHA for 02a11fc

• SiriusUid field not existent should be handled.

  cooperaj

  committed
  90170c3

  Copy full SHA for 90170c3

• UML-3394 fixed lint

  

  allenannom

  authored and

  cooperaj

  committed
  78e8306

  Copy full SHA for 78e8306

• UML-3394 fixed broken test & PersonDataFormatterTest.php

  

  allenannom

  authored and

  cooperaj

  committed
  259a016

  Copy full SHA for 259a016

• The waitforit application we use in seeding has changed ownership.

  Show description for 65f6041
  cooperaj

  committed
  65f6041

  Copy full SHA for 65f6041

• Ensure we handle modernise records in the DB when the combined format flag is turned off.

  Show description for d84280a
  cooperaj

  committed
  d84280a

  Copy full SHA for d84280a

• Code tidy ups after rebase

  cooperaj

  committed
  a2685c1

  Copy full SHA for a2685c1

• Fix test namespaces to stop composer autoload errors

  cooperaj

  committed
  3a2fbad

  Copy full SHA for 3a2fbad

• Reinstate the remove lpa fix from UML-3791

  cooperaj

  committed
  d1d81aa

  Copy full SHA for d1d81aa

Commits on Jan 20, 2025

• Remove added feature flag from behat test configuration

  cooperaj

  committed
  461ed67

  Copy full SHA for 461ed67