-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored operation polling to only request active operation #53
Conversation
@timbrigham-oc - Can you try this branch for me and see if it solves your problem? i.e.
and let me know how it goes |
@elegantmoose, I just looked at this. I do definitely see a change in behavior, it looks like it's now only pulling the specs from the currently executing operation. Very good change IMO, something I was looking at how to do myself. :) If I pick one of my larger lateral movement tests it's around 1.5 megabytes each pull, still much better then it has been. I am still seeing refreshes occurring on finished operations. Know that wasn't the intent of that branch, just noting its happening. This has dropped my network usage by an order of magnitude. |
Awesome. Ill look at the finished operations polling and see if also quick fix. Either way Ill merge this partial fix today. |
@timbrigham-oc Pull branch again and see if network traffic gets more reduced. (added check for finished operations) |
@elegantmoose , I'm in the middle of a test sequence now, I'll check back on this in the morning. |
@timbrigham-oc no rush 👍 |
Ok, following up. :) On a preliminary look I'm still seeing operations updating on running tasks where the data refreshing only for the active operation, so that behavior still looks good. The refreshes on finished operations are also not firing, so that should be good as well. |
@elegantmoose, I'm seeing an issue that might (I haven't made any other code changes, and just noticed this now) be caused by this update. The 'Filters' view is not being restricted to only only host / agent IDs and abilities that are relevant to a given operation. You can see that this operation ran against one agent and only used three abilities (nma, reverse lookup ip, dns match) The abilities, in the filter view are showing every possible ability from the adversary definition, and every agent ID. |
It's strange.. the same exact contents on that dialog will also show, regardless of which operation I have selected. I'm guessing it might be something along the line of whichever operation I select first - if I then select another operation - isn't getting updated. |
Yea, that was probably me that introduced those. Ill take a look at ASAP. Opened new issue - mitre/caldera#3004 |
Potentially: