Register Phi 3.5 moe SUT + Add "instruct" to Phi UIDs #707
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
rogthefrog
reviewed
Nov 21, 2024
| SUTS.register( | ||
| AzureChatSUT, | ||
| "phi-3.5-moe-instruct", | ||
| "https://Phi-3-5-MoE-instruct-abneb.eastus2.models.ai.azure.com", |
There was a problem hiding this comment.
Do we want to make this a secret? That way it's not hardcoded.
There was a problem hiding this comment.
I think it's fine to hardcode unless its actually a "secret"
There was a problem hiding this comment.
We really need to run these tests, so let's hardcode it for now. In the future we should talk about config that isn't secrets.
wpietri
approved these changes
Nov 22, 2024
|
And sorry to be rude, but I'm merging this so I can build the hopefully-final docker image. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.