Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register Phi 3.5 moe SUT + Add "instruct" to Phi UIDs #707

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Register Phi 3.5 moe SUT + Add "instruct" to Phi UIDs #707

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a19920
register phi-3.5-moe sut
bkorycki Nov 21, 2024
e130ea9
Append -instruct to uids
bkorycki Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion plugins/azure/modelgauge/suts/azure_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,21 @@ def scope(cls) -> str:
return "azure_phi_3_5_mini_endpoint"


class PhiMoEKey(AzureApiKey):
@classmethod
def scope(cls) -> str:
return "azure_phi_3_5_moe_endpoint"


SUTS.register(
AzureChatSUT,
"phi-3.5-mini",
"phi-3.5-mini-instruct",
"https://Phi-3-5-mini-instruct-hfkpb.eastus2.models.ai.azure.com",
InjectSecret(PhiMiniKey),
)
SUTS.register(
AzureChatSUT,
"phi-3.5-moe-instruct",
"https://Phi-3-5-MoE-instruct-abneb.eastus2.models.ai.azure.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make this a secret? That way it's not hardcoded.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to hardcode unless its actually a "secret"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to run these tests, so let's hardcode it for now. In the future we should talk about config that isn't secrets.

InjectSecret(PhiMoEKey),
)