Selection city #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
next-exp#663 [author: carmenromo] NEW Database has been uploaded with the gains for SiPMs and PMTs as well as the pdfs based on the calibrations from run 7389. SiPM 25043 has shown a suspicious behaviour. For the moment we won't mask it, but will keep an eye on it. [reviewer: jmbenlloch] Latest calibration added and all tests passed. Approved!
[author: paolafer] This is an extremely simple PR, in which I change the string length to store the name of the creator process of an MC particle, following the change implemented in nexus. There are hadronic processes whose names are longer than 20 characters, which was the length previously set. [reviewer: andLaing] Simple change that makes a more diverse set of data labels possible
next-exp#669 [author: carmenromo] NEW Database has been uploaded with the gains for SiPMs and PMTs as well as the pdfs based on the calibrations from run 7522. SiPM 25043 is now working correctly. [reviewer: andLaing] Database update with new gain parameters. No major changes with the exception of recovering one SiPM. Approved.
next-exp#670 [author: carmenromo] NEW Database has been uploaded with the gains for SiPMs and PMTs as well as the pdfs based on the calibrations from run 7572. We also have seen that SiPM 21051 is dead since run 7563, so we have masked it. [reviewer: jmbenlloch] Latest calibration correctly included and all tests passed. Approved!
next-exp#654 [author: paolafer] In this PR I changed the function called by `load_mchits()`, which loads the true MC hits of a range of events in a file. The previous function loads all the true information (including particles) and returns only hits, while this function loads only the hits. The time is reduced to ~75% of the original time, for a file of ~8000 events of 511-keV gamma interactions, therefore I thought that this new implementation could be worth it. I haven't added any test, because we have already a test for the `load_mchits() function, which uses internally the new function. This change should be transparent to the user. [reviewer: mmkekic] This PR adds a more efficient way to read mchit info only from MC tables, with a minimal change to existing functions. Good job :)
Using the trigger1 merged kdst for run 6971 I get this numbers: Before: Time spent in get_maps_coefficient: 27.98320436477661 s After : Time spent in get_maps_coefficient: 0.324688196182251 s
next-exp#673 [author: gonzaponte] This commit speeds up the most time-consuming part of applying corrections. For a single call to apply_all_corrections: Time spent in get_normalization_factor: 0.0007276535034179688 s Time spent in maps_coefficient_getter: 0.00017762184143066406 s Time spent in maps_coefficient_getter: 0.00012445449829101562 s Time spent in apply_all_correction_single_maps: 0.0012238025665283203 s Time spent in get_maps_coefficient: 27.98320436477661 s Time spent in time_coefs_corr: 0.024751663208007812 s Time spent in correct_geometry_: 0.003904581069946289 s Time spent in get_maps_coefficient: 25.5330171585083 s Time spent in time_coefs_corr: 0.018788576126098633 s Time spent in correct_lifetime_: 0.018901586532592773 s The new implementation takes advantage of numpy's internal C-speed loops to retrieve the data faster. Using the trigger1 merged kdst for run 6971 I get this numbers: Before: Time spent in get_maps_coefficient: 27.98320436477661 s After : Time spent in get_maps_coefficient: 0.324688196182251 s [reviewer: mmkekic] This function significantly speeds up the lookup for the corresponding map coefficient from the map dataframe. No tests are needed since the old function was already tested. Good job!
assert DST table inside file, assert summary table the same except dropped columns, assert DST the same as in Penthesilea.
Adds kdst_from_df_writer, removes columns from summary table
next-exp#681 [author: mmkekic] There are some nonphysical events that have more than 10s of thousands hits. This PR makes Esmeralda not run tracking functions on events that have too many hits. [reviewer: gonzaponte] New filter for Esmeralda skipping events with too many hits. Adds a good and readable test. Good job!
next-exp#682 [author: carmenromo] This PR includes the latest sensor calibrations from run 7641. Database has been uploaded with the PMT and SiPMs gains and the pdf values. SiPM 21051 is alive again so it has been unmasked. [reviewer: jmbenlloch] New calibration added and all tests are working. Approved!
next-exp#684 [author: carmenromo] This PR includes the latest sensor calibration for DEMO++. SiPM and PMT gains have been uploaded as well as pdfs from run 7053. [reviewer: jmbenlloch] Latest DEMO++ calibration correctly added. Approved!
Only uses positive charge for weighting to avoid non-sequential bins.
Data had a peak affected by -ve charges data updated to represent new expectation
next-exp#687 [author: andLaing] This PR reopens next-exp#658 with an added patch to protect against attempts to rebin using only negative charge bins. Tests are added to demonstrate the problems and their solution. [reviewer: mmkekic] This PR demonstrates and fixes the bug in weighted rebinning of the waveforms with negative weights. The change is minimal and clear, and the test are relevant for any kind of future refactoring of irene city. Good job!
next-exp#688 [author: carmenromo] In the last month, runs with different SiPMs voltages were taken, so database has been uploaded with the corresponding gains for each voltage. [reviewer: jmbenlloch] Latest calibration properly added, all tests passed.
next-exp#686 [author: ausonandres] The purpose of this PR is to remove some parameters (pmt_sample_frequency=25 ns, sipm_sample_frequency=1 mus, and ratio=40) that were hard-coded in some functions of `peak_functions.py`. Now, they are defined in the input of the city (since they should not change their values), and could be specified in config file. [reviewer: andLaing] Some simple changes that remove hardwired numbers from the PMap construction steps. Makes things more flexible for future updates and is tested.
next-exp#689 [author: jmbenlloch] Travis has started to fail in IC installations due to a newer version of the coverage package, which is not listed in our dependencies list but it is need by one of them. This PR simply fixes the coverage version manually so new installations won't get the failing one. [reviewer: paolafer] This PR fixes a problem with hypothesis, caused by newer version of the coverage package. The tests succeed, therefore I approve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an essential feature to IC, without which we cannot live anymore.