193 add isolation forrest conversion to treeexplainer #289
+310
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mmschlk
requested changes
Dec 15, 2024
There was a problem hiding this comment.
The implementation looks good and I do not see any problems there. However, before we can merge this we need to address the following two concerns:
- Add unit tests (with hopefully 100% coverage) in
tests/tests_explainer/tests_tree_explainer/tests_explainer which then will be run on any unit-test run by the CI (this needs to be quick and easy) - Run the code-quality checks (black and ruff) which is defined in
.github/CONTRIBUTING.mdand the.pre-commit-config.yaml
r-visser
force-pushed
the
193-add-isolation-forrest-conversion-to-treeexplainer
branch
from
d6457d4 to
9bae0d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add conversion module for the Isolation Forest algorithm
resolve #278