Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate from deprecated upload-artifact #2878

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

bashmish
Copy link
Member

@bashmish bashmish commented Jan 31, 2025

What I did

  1. Migrated from upload-artifact@v3 to upload-artifact@v4, it contains breaking changes, so I updated accordingly
    upload-artifact@v3 was deprecated in November 2024 and completely stopped working in one of recent PRs failing the build, so I needed to do that to bring Storybook Builder tests back to a working state
  2. Combined Linux & Windows builds of Storybook Builder into a matrix, just saw an example how to do that keeping the flow the same, so DRYed it
  3. Bumped Node to 22 in Storybook Builder tests

Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: 7f7abff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bashmish bashmish force-pushed the chore/migrate-from-deprecated-upload-artifact branch 2 times, most recently from 863eeaa to 811e45a Compare January 31, 2025 15:52
@bashmish bashmish force-pushed the chore/migrate-from-deprecated-upload-artifact branch from 811e45a to 7f7abff Compare January 31, 2025 15:55
@bashmish bashmish merged commit cdaf1c1 into master Jan 31, 2025
7 of 9 checks passed
@bashmish bashmish deleted the chore/migrate-from-deprecated-upload-artifact branch January 31, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant