Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate from deprecated upload-artifact #2878

Merged
merged 1 commit into from
Jan 31, 2025
Merged

chore: migrate from deprecated upload-artifact #2878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 11 additions & 44 deletions .github/workflows/verify-storybook-builder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,23 @@ name: Verify Storybook Builder
on: pull_request

jobs:
verify-storybook-builder-linux:
verify-storybook-builder:
strategy:
fail-fast: false
matrix:
runs-on: [ubuntu-22.04, windows-2022]
runs-on: ${{ matrix.runs-on }}
name: ${{ matrix.runs-on }}
timeout-minutes: 60
name: Linux
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4

- name: Setup Node 20
- name: Setup Node 22
uses: actions/setup-node@v4
env:
FORCE_COLOR: 0
with:
node-version: 20
node-version: 22
cache: npm

- name: Install Dependencies
Expand All @@ -33,46 +37,9 @@ jobs:
- name: Run tests
run: npm run test:storybook-builder

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: always()
with:
name: playwright-report
path: packages/storybook-framework-web-components/playwright-report/
retention-days: 30

verify-storybook-builder-windows:
timeout-minutes: 60
name: Windows
runs-on: windows-2022
steps:
- uses: actions/checkout@v4

- name: Setup Node 20
uses: actions/setup-node@v4
env:
FORCE_COLOR: 0
with:
node-version: 20
cache: npm

- name: Install Dependencies
run: npm ci

- name: Build packages
run: npm run build

- name: Symlink built packages binaries (e.g. "wds")
run: npm ci

- name: Install Playwright Browsers
run: npx playwright install --with-deps

- name: Run tests
run: npm run test:storybook-builder

- uses: actions/upload-artifact@v3
if: always()
with:
name: playwright-report
name: playwright-report-${{ matrix.runs-on }}
path: packages/storybook-framework-web-components/playwright-report/
retention-days: 30
Loading