feat(utils): move utils from modflow-devtools #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1621 +/- ##
=========================================
- Coverage 72.8% 71.6% -1.3%
=========================================
Files 252 253 +1
Lines 54551 55729 +1178
=========================================
+ Hits 39747 39902 +155
- Misses 14804 15827 +1023
|
wpbonelli
force-pushed
the
relocate-from-devtools
branch
4 times, most recently
from
c4a6525 to
c1ca09c
Compare
wpbonelli
force-pushed
the
relocate-from-devtools
branch
2 times, most recently
from
a38934b to
4b37fa3
Compare
wpbonelli
force-pushed
the
relocate-from-devtools
branch
from
4b37fa3 to
fe42a91
Compare
* add head and budget file writing util fns * add disu creation helper fn * add uniform flow field fn * add head/budget/concentration comparison utility fns * add namefile-reading utility fn * lint tests and notebook utils * add test for HeadUFile.get_ts() * add minimal tests for relocated utils
wpbonelli
force-pushed
the
relocate-from-devtools
branch
from
fe42a91 to
25d6697
Compare
langevin-usgs
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move utilities that seem in-scope for
flopyfrommodflow-devtools(originally frompymake)Minimal tests are added for the last three items. The first two have either extremely minimal tests or (skipped) empty stubs. This PR will allow refactored modflow6 tests in MODFLOW-USGS/modflow6#1066 to import from FloPy instead of pymake. I'm planning to return to this and expand the tests after getting more comfortable with how they're used in modflow6 autotests.
Both items below were moved to #1665
add a test for bug: flopy.utils.binaryfile.HeadUFile.get_ts() gives error for idx= 0 #1519import shared fixtures and utilities frommodflow-devtools