refactor(tests): use modflow-devtools fixtures and utilities #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1665 +/- ##
=========================================
- Coverage 72.7% 71.5% -1.3%
=========================================
Files 252 252
Lines 54554 53194 -1360
=========================================
- Hits 39714 38036 -1678
- Misses 14840 15158 +318
|
langevin-usgs
approved these changes
Dec 20, 2022
wpbonelli
force-pushed
the
use-devtools
branch
2 times, most recently
from
675d7b4 to
40471d6
Compare
wpbonelli
force-pushed
the
use-devtools
branch
from
40471d6 to
11e533e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modflow-devtoolsnow has test fixtures and utilities that can be shared by FloPy, Modflow6 and other repos. Configuremodflow-devtoolsas apytestplugin inautotest/conftest.py, allowing tests to use fixtures, CLI options and configuration hooks defined upstream. Update marker imports in test files. TrimDEVELOPER.md, removing sections on utilities moved tomodflow-devtools, and link to the docs there instead. Also add info on using.envfiles to configure environment variables needed for tests, e.g.GITHUB_TOKEN.Some code previously in
autotest/conftest.pyand now inmodflow-devtoolswas contributed by @mwtoews. Since authorship was lost on the move between repos I added notes to docstrings but if I have missed any please let me know.This PR was originally interwoven with #1621, extracted here for smaller and more focused changesets.