-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime): checking for remote entry type when loading assets #2753
fix(runtime): checking for remote entry type when loading assets #2753
Conversation
🦋 Changeset detectedLatest commit: 1cc0ef7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@ScriptedAlchemy @2heal1 Are these tests flaky or should I look at why these are failing ? |
I see that other PRs also have this problem. Can this be merged ? |
I have a question: Will you change the remote.type as 'module' ? Because we don't add the attr in manifest currently |
@2heal1 isnt the remoteType in manifest "esm" when its esm mode? |
@ScriptedAlchemy I check the manifest again , the remoteInfo.type will use |
Can we merge this ? |
@ScriptedAlchemy @2heal1 This one liner PR has been waiting for almost 2 weeks. Can we merge it ? |
Description
Related Issue
Types of changes
Checklist